Bug 31296 - Add ability to disable demagnetizing items via SIP2 based on itemtypes
Summary: Add ability to disable demagnetizing items via SIP2 based on itemtypes
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 26370
Blocks:
  Show dependency treegraph
 
Reported: 2022-08-05 11:12 UTC by Kyle M Hall
Modified: 2022-08-08 16:21 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes (7.30 KB, patch)
2022-08-05 11:15 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes (7.35 KB, patch)
2022-08-05 12:49 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes (7.35 KB, patch)
2022-08-05 12:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31296: (QA follow-up) Add to debian templates (1007 bytes, patch)
2022-08-05 12:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31296: (QA follow-up) Fix trivial spelling errors (1.01 KB, patch)
2022-08-08 16:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2022-08-05 11:12:36 UTC
Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library.
Comment 1 Kyle M Hall 2022-08-05 11:15:19 UTC
Created attachment 138681 [details] [review]
Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes

Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t
Comment 2 Martin Renvoize 2022-08-05 12:49:28 UTC
Created attachment 138691 [details] [review]
Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes

Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2022-08-05 12:53:40 UTC
Created attachment 138692 [details] [review]
Bug 31296: Add ability to disable demagnetizing items via SIP2 based on itemtypes

Some libraries have certain item types that can only do in house checkouts via SIP self check machines. In these cases, the items should not be demagnetized since the items cannot leave the library.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-08-05 12:53:45 UTC
Created attachment 138693 [details] [review]
Bug 31296: (QA follow-up) Add to debian templates

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2022-08-05 12:54:56 UTC
Going straight for QA on this one.

Works as expected and is covered by tests.. example configs also updated.

Passing QA.

Please also add it to the wiki page detailing all the SIP options ;P

I'd love to eventually see some of this stuff move to UI side configurations, but didn't want to hold this one up.
Comment 6 Tomás Cohen Arazi 2022-08-08 16:19:28 UTC
Created attachment 138842 [details] [review]
Bug 31296: (QA follow-up) Fix trivial spelling errors

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi 2022-08-08 16:21:18 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!