|
Description
Andrew Fuerste-Henry
2020-09-03 19:20:07 UTC
It's not completely true, some of this information, like the library and location are also shown in the OPAC if you choose not to create items. The library is also used for access control to subscriptions. Good correction, thanks! I think Call number is shown as well - that would only leave us with the item types. Not sure what a good GUI improvement could look like here. Now that the form has collection and itemtype, perhaps we could enable or disable the fields based on whether the "Create an item record when receiving this serial" button is checked? Created attachment 134968 [details]
Perhaps we hide fields based on which option is selected?
Created attachment 135355 [details] [review] Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. I believe collection might also be shown somewhere outside of items, but I do not remember clearly from testing the patch. Just something to test here to make sure! I verified, the patches had no changes to the OPAC template files, sorry for doubting you! Created attachment 135455 [details] [review] Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. Signed-off-by: David Nind <david@davidnind.com> Created attachment 135479 [details] [review] Bug 26377: Show when loading the page if needed Prevent a blink Created attachment 135480 [details] [review] Bug 26377: Simplify JS code Owen, do you agree with those 2 patches? Created attachment 135491 [details] [review] Bug 26377: Show when loading the page if needed Prevent a blink Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 135492 [details] [review] Bug 26377: Simplify JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 135500 [details] [review] Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 135501 [details] [review] Bug 26377: Show when loading the page if needed Prevent a blink Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 135502 [details] [review] Bug 26377: Simplify JS code Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 not feeling very confident while trying to fix the conflicts after applying on 21.11. Please provide backport if needed. Best, |