Bug 26387

Summary: Suppress Holds Queue warning if hold is bib level and has an itemtype set
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Hold requestsAssignee: Kyle M Hall <kyle>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: didier.gautheron, gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 26387: Suppress Holds Queue warning if hold is bib level and has an itemtype set

Description Kyle M Hall 2020-09-04 12:28:16 UTC
If a hold is record level with an itemtype selected, a warning will be generated by the holds queue builder because $request->{itemnumber} }->{itype}.
Comment 1 Kyle M Hall 2020-09-04 12:30:36 UTC
Created attachment 109655 [details] [review]
Bug 26387: Suppress Holds Queue warning if hold is bib level and has an itemtype set

If a hold is record level with an itemtype selected, a warning will be generated by the holds queue builder because $request->{itemnumber} }->{itype}.

Test Plan:
1) Enable choosing of itemtype for holds
2) Place a bib level holds with an itemtype selected
3) Run holds queue builder
4) Note the warning
5) Apply this patch
6) Run the holds queue builder again
7) No warning!
Comment 2 Didier Gautheron 2021-01-17 07:33:27 UTC
Fixed in  #26367

*** This bug has been marked as a duplicate of bug 26367 ***