Summary: | OPAC renewal failure due to automatic renewal does not have a failure message | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrewfh> |
Component: | OPAC | Assignee: | Lucas Gass <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.06
|
|
Attachments: |
Bug 26389: Add auto renewal error to opac-user.tt
Bug 26389: Add auto renewal error to opac-user.tt Bug 26389: Add auto renewal error to opac-user.tt |
Description
Andrew Fuerste-Henry
2020-09-04 13:50:36 UTC
Created attachment 109685 [details] [review] Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error System preference OpacRenewalAllowed must be on "Allow" (In reply to Lucas Gass from comment #1) > Created attachment 109685 [details] [review] [review] > Bug 26389: Add auto renewal error to opac-user.tt > > Test plan: > 1 Check out an auto-renewing item to a patron > 2 confirm in circ rules that the rule allows at least one renewal > 3 log into OPAC, confirm your summary shows item is scheduled for > auto-renewal > 4 click Renew All I was able to display "Renew All" when item is in auto-renewal. But one can run directly the URL to simulate it : /cgi-bin/koha/opac-renew.pl?from=opac_user&item=<itemnumber>&borrowernumber=<borrowernumber> Created attachment 110892 [details] [review] Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 111459 [details] [review] Bug 26389: Add auto renewal error to opac-user.tt Test plan: 1 Check out an auto-renewing item to a patron 2 confirm in circ rules that the rule allows at least one renewal 3 log into OPAC, confirm your summary shows item is scheduled for auto-renewal 4 click Renew All 5 Get note "Please note: Your loan renewal failed because of the following reason(s):" with no following reasons 6 Apply patch 7 Repeat 3-5 8 See appropriate error Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.06 I can't reproduce this in 19.11.x. Clicking Renew All doesn't do anything at all - no error. not backported |