Bug 26393

Summary: Add cache on Koha::CirculationRules::get_effective_rule
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Architecture, internals, and plumbingAssignee: Fridolin Somers <fridolin.somers>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: arthur.suzuki, julian.maurice
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26424
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

Description Fridolin Somers 2020-09-04 15:23:58 UTC
For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.
Comment 1 Fridolin Somers 2020-09-04 15:28:13 UTC
Created attachment 109670 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.

Adds a constant CACHE_NO_CIRCULATION_RULE_VALUE to store a special
value when method must return undef.
Comment 2 Fridolin Somers 2020-09-04 15:28:55 UTC
You may look at patch, test plan is comming
Comment 3 Fridolin Somers 2020-09-09 14:46:53 UTC
Created attachment 109827 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.

Adds a constant CACHE_NO_CIRCULATION_RULE_VALUE to store a special
value when method must return undef.
Comment 4 Fridolin Somers 2020-09-10 09:00:53 UTC
Created attachment 109839 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.

Adds a constant CACHE_NO_CIRCULATION_RULE_VALUE to store a special
value when method must return undef.
Comment 5 Fridolin Somers 2020-09-10 09:01:41 UTC
Created attachment 109840 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.
Comment 6 Fridolin Somers 2020-09-10 12:06:33 UTC
Created attachment 109846 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.
Comment 7 Fridolin Somers 2020-09-18 12:55:50 UTC
Arf my tests dont prove a performance difference.

Foud Bug 26424 is a real performance improvement.

I set to in discussion in case someone is interested.
Comment 8 Fridolin Somers 2022-12-05 08:10:51 UTC

*** This bug has been marked as a duplicate of bug 29623 ***