Bug 26393 - Add cache on Koha::CirculationRules::get_effective_rule
Summary: Add cache on Koha::CirculationRules::get_effective_rule
Status: RESOLVED DUPLICATE of bug 29623
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-04 15:23 UTC by Fridolin Somers
Modified: 2022-12-05 08:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule (1.92 KB, patch)
2020-09-04 15:28 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule (2.48 KB, patch)
2020-09-09 14:46 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule (2.27 KB, patch)
2020-09-10 09:00 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule (2.17 KB, patch)
2020-09-10 09:01 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule (2.25 KB, patch)
2020-09-10 12:06 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2020-09-04 15:23:58 UTC
For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.
Comment 1 Fridolin Somers 2020-09-04 15:28:13 UTC
Created attachment 109670 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.

Adds a constant CACHE_NO_CIRCULATION_RULE_VALUE to store a special
value when method must return undef.
Comment 2 Fridolin Somers 2020-09-04 15:28:55 UTC
You may look at patch, test plan is comming
Comment 3 Fridolin Somers 2020-09-09 14:46:53 UTC
Created attachment 109827 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.

Adds a constant CACHE_NO_CIRCULATION_RULE_VALUE to store a special
value when method must return undef.
Comment 4 Fridolin Somers 2020-09-10 09:00:53 UTC
Created attachment 109839 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.

Adds a constant CACHE_NO_CIRCULATION_RULE_VALUE to store a special
value when method must return undef.
Comment 5 Fridolin Somers 2020-09-10 09:01:41 UTC
Created attachment 109840 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.
Comment 6 Fridolin Somers 2020-09-10 12:06:33 UTC
Created attachment 109846 [details] [review]
Bug 26393: Add cache on Koha::CirculationRules::get_effective_rule

For performance of several circulation pages we should cache the result of method Koha::CirculationRules::get_effective_rule.
Comment 7 Fridolin Somers 2020-09-18 12:55:50 UTC
Arf my tests dont prove a performance difference.

Foud Bug 26424 is a real performance improvement.

I set to in discussion in case someone is interested.
Comment 8 Fridolin Somers 2022-12-05 08:10:51 UTC

*** This bug has been marked as a duplicate of bug 29623 ***