Bug 26502

Summary: ExpireReservesMaxPickUpDelayCharge allows invalid values to be set
Product: Koha Reporter: Joonas Kylmälä <joonas.kylmala>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, nugged, slavashishkin, stalkernoid
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Joonas Kylmälä 2020-09-21 14:11:57 UTC
One can set invalid values like "0,00" to the syspref ExpireReservesMaxPickUpDelayCharge and it will cause the cronjobs/holds/cancel_expired_holds.pl to fail:

> Argument "0,00" isn't numeric in numeric gt (>) at [...]

Expected behaviour: When setting the syspref in the staff interface Koha should should disallow setting invalid values.
Comment 1 Joonas Kylmälä 2020-09-25 12:03:51 UTC
I found out that 0.00 is invalid value, too because 0 fees cannot be set. 0 works however.