Bug 26502 - ExpireReservesMaxPickUpDelayCharge allows invalid values to be set
Summary: ExpireReservesMaxPickUpDelayCharge allows invalid values to be set
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-21 14:11 UTC by Joonas Kylmälä
Modified: 2020-09-25 12:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kylmälä 2020-09-21 14:11:57 UTC
One can set invalid values like "0,00" to the syspref ExpireReservesMaxPickUpDelayCharge and it will cause the cronjobs/holds/cancel_expired_holds.pl to fail:

> Argument "0,00" isn't numeric in numeric gt (>) at [...]

Expected behaviour: When setting the syspref in the staff interface Koha should should disallow setting invalid values.
Comment 1 Joonas Kylmälä 2020-09-25 12:03:51 UTC
I found out that 0.00 is invalid value, too because 0 fees cannot be set. 0 works however.