Summary: | New items not indexed | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrewfh> |
Component: | Searching - Elasticsearch | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P5 - low | CC: | aleisha, chad, jonathan.druart, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.05
|
|
Bug Depends on: | 23463 | ||
Bug Blocks: | 25265, 26972 | ||
Attachments: |
Bug 26507: Index records after storing new item
Bug 26507: Index records after storing new item Bug 26507: Elasticsearch - Index records after storing new item Bug 26507: [20.05.x] Elasticsearch - Index records after storing new item |
Description
Andrew Fuerste-Henry
2020-09-22 13:59:54 UTC
Created attachment 110558 [details] [review] Bug 26507: Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Created attachment 110567 [details] [review] Bug 26507: Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Created attachment 110620 [details] [review] Bug 26507: Elasticsearch - Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! Any chance this will be backported to 20.05.x? (In reply to chad from comment #5) > Any chance this will be backported to 20.05.x? It' always up to the RMaints, but the usual rule of thumb is that bug fixes will be backported if the bug exists in the earlier version. does not apply cleanly to 20.05.x, if needed please rebase Created attachment 110879 [details] [review] Bug 26507: [20.05.x] Elasticsearch - Index records after storing new item Currently Item->store indexes the record before the DB update - that is wrong To test: 1 - Find/create a bib with no items 2 - add an item with barcode "abc123" 3 - do a general keyword search for "abc123," see your bib is not in the results 4 - perform a search that includes your bib in the results, confirm it shows as having no items 5 - click through to bib details, confirm it shows your item here 6 - edit and save your item 7 - confirm barcode is now searchable 8 - apply patches 9 - Add a new item "cde456" 10 - Confirm it returns in searches 11 - Edit 'cde456' and change barcode to 'fgh789' 12 - Confirm the new abrcode is searchable Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> backported to 20.05.x for 20.05.05 missing dependencies, not backported to 19.11.x This caused bug 26972. Nick, can you have a look please? |