| Summary: | Make housebound module show delivery preferences when scheduling | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Donna <bwsdonna> |
| Component: | Patrons | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, gmcharlt, jonathan.druart, kyle.m.hall, kyle, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 28810 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 26544: Add housebound details to delivery page
Bug 26544: Add housebound details to delivery page Bug 26544: Add housebound details to delivery page Bug 26544: Add housebound details to delivery page |
||
|
Description
Donna
2020-09-25 21:10:57 UTC
+1, why would we collect this data but not make it visible in the screen where it matters? Created attachment 123290 [details] [review] Bug 26544: Add housebound details to delivery page To test: 1. Turn on the housebound module 2. go to the housebound for a given patron /cgi-bin/koha/members/housebound.pl?borrowernumber=X 3. add some housebound details, fill out all the fields 4. Go to 'Add a new delivery' 5. No housebound details, hard to know what the patron likes or days to deliver! 6. apply patch 7. Go to 'Add a delivery' 8. See the housebound details. yay! Created attachment 123334 [details] [review] Bug 26544: Add housebound details to delivery page To test: 1. Turn on the housebound module 2. go to the housebound for a given patron /cgi-bin/koha/members/housebound.pl?borrowernumber=X 3. add some housebound details, fill out all the fields 4. Go to 'Add a new delivery' 5. No housebound details, hard to know what the patron likes or days to deliver! 6. apply patch 7. Go to 'Add a delivery' 8. See the housebound details. yay! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Looking at bug 28810 just before: do we not want to preserve the new lines here as well? Also it might be nice to add some IDs to the <li> to help people hide some information if it turns out a little much (not blocker, just suggesting) Realizing this puts repeated mark-up in a BLOCK (excellent) which is probably the reason it currently conflicts with bug 28810. I think as 28810 is already PQA it would be good to make this apply cleanly on top - also helping to avoid regressions like the line breaks. Created attachment 124432 [details] [review] Bug 26544: Add housebound details to delivery page To test: 1. Turn on the housebound module 2. go to the housebound for a given patron /cgi-bin/koha/members/housebound.pl?borrowernumber=X 3. add some housebound details, fill out all the fields 4. Go to 'Add a new delivery' 5. No housebound details, hard to know what the patron likes or days to deliver! 6. apply patch 7. Go to 'Add a delivery' 8. See the housebound details, yay! All the line breaks should be preserved. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 125322 [details] [review] Bug 26544: Add housebound details to delivery page To test: 1. Turn on the housebound module 2. go to the housebound for a given patron /cgi-bin/koha/members/housebound.pl?borrowernumber=X 3. add some housebound details, fill out all the fields 4. Go to 'Add a new delivery' 5. No housebound details, hard to know what the patron likes or days to deliver! 6. apply patch 7. Go to 'Add a delivery' 8. See the housebound details, yay! All the line breaks should be preserved. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |