Summary: | Show value of global system preferences on subscription form | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Serials | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andrew, colin.campbell, jonathan.druart, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 26549: Show value of global system preferences on subscription form
Bug 26549: Show value of global system preferences on subscription form Bug 26549: Show value of global system preferences on subscription form Bug 26549: Show value of global system preferences on subscription form |
Description
Katrin Fischer
2020-09-26 10:14:28 UTC
Created attachment 134937 [details] [review] Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. *** Bug 26378 has been marked as a duplicate of this bug. *** Created attachment 134940 [details] [review] Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. Signed-off-by: David Nind <david@davidnind.com> Created attachment 135110 [details] [review] Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Please rebase. Created attachment 138067 [details] [review] Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Rebased and tested. Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to 22.05.x series |