Bug 26549 - Show value of global system preferences on subscription form
Summary: Show value of global system preferences on subscription form
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
: 26378 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-26 10:14 UTC by Katrin Fischer
Modified: 2022-05-13 01:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26549: Show value of global system preferences on subscription form (4.05 KB, patch)
2022-05-12 16:07 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 26549: Show value of global system preferences on subscription form (4.10 KB, patch)
2022-05-13 01:05 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-09-26 10:14:28 UTC
If "Number of issues to display to ...:" input fields in the subscription form are left empty, the global values from the *SerialIssueDisplayCount system preferences are used.

It would be nice to display a hint about the pref value on the form to help decide if you want overwrite it or not.
Comment 1 Owen Leonard 2022-05-12 16:07:01 UTC
Created attachment 134937 [details] [review]
Bug 26549: Show value of global system preferences on subscription form

This patch modifies the subscription entry form so that the values of
two system preferences are displayed as a hint to the user:

The "Number of issues to display to staff" field will show the value
of the StaffSerialIssueDisplayCount preference, and the "Number of
issues to display to the public" field will show
OPACSerialIssueDisplayCount. If the user has permission the system
preference names will link to the system preferences page.

To test, apply the patch and log into the staff interface as a user with
permission to edit system preferences.

- Go to Serials -> New subscription.
- The "Number of issues to display to staff" field should have a hint
  under it: "Default: XX (StaffSerialIssueDisplayCount system
   preference)"
- The "Number of issues to display to the public" field should have a
  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
  preference)"
- Log out and log back in as a user who does not have permission to edit
  system preferences. Return to the form and confirm that the hints do
  not link to system preferences.
Comment 2 Owen Leonard 2022-05-12 16:27:12 UTC
*** Bug 26378 has been marked as a duplicate of this bug. ***
Comment 3 David Nind 2022-05-13 01:05:29 UTC
Created attachment 134940 [details] [review]
Bug 26549: Show value of global system preferences on subscription form

This patch modifies the subscription entry form so that the values of
two system preferences are displayed as a hint to the user:

The "Number of issues to display to staff" field will show the value
of the StaffSerialIssueDisplayCount preference, and the "Number of
issues to display to the public" field will show
OPACSerialIssueDisplayCount. If the user has permission the system
preference names will link to the system preferences page.

To test, apply the patch and log into the staff interface as a user with
permission to edit system preferences.

- Go to Serials -> New subscription.
- The "Number of issues to display to staff" field should have a hint
  under it: "Default: XX (StaffSerialIssueDisplayCount system
   preference)"
- The "Number of issues to display to the public" field should have a
  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
  preference)"
- Log out and log back in as a user who does not have permission to edit
  system preferences. Return to the form and confirm that the hints do
  not link to system preferences.

Signed-off-by: David Nind <david@davidnind.com>