26549 – Show value of global system preferences on subscription form

Bug 26549 - Show value of global system preferences on subscription form

Summary: Show value of global system preferences on subscription form

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Serials (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Owen Leonard
QA Contact:	Testopia

URL:
Keywords:

Duplicates (1):	26378 (view as bug list)
Depends on:
Blocks:

Reported:	2020-09-26 10:14 UTC by Katrin Fischer
Modified:	2023-12-28 20:43 UTC (History)
CC List:	5 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	22.11.00
Circulation function:

Attachments
Bug 26549: Show value of global system preferences on subscription form (4.05 KB, patch) 2022-05-12 16:07 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 26549: Show value of global system preferences on subscription form (4.10 KB, patch) 2022-05-13 01:05 UTC, David Nind	Details \| Diff \| Splinter Review
Bug 26549: Show value of global system preferences on subscription form (4.17 KB, patch) 2022-05-18 13:30 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 26549: Show value of global system preferences on subscription form (4.78 KB, patch) 2022-07-24 22:05 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Katrin Fischer 2020-09-26 10:14:28 UTC

If "Number of issues to display to ...:" input fields in the subscription form are left empty, the global values from the *SerialIssueDisplayCount system preferences are used.

It would be nice to display a hint about the pref value on the form to help decide if you want overwrite it or not.

Comment 1 Owen Leonard 2022-05-12 16:07:01 UTC Comment hidden (obsolete)

Created attachment 134937 [details] [review]
Bug 26549: Show value of global system preferences on subscription form

This patch modifies the subscription entry form so that the values of
two system preferences are displayed as a hint to the user:

The "Number of issues to display to staff" field will show the value
of the StaffSerialIssueDisplayCount preference, and the "Number of
issues to display to the public" field will show
OPACSerialIssueDisplayCount. If the user has permission the system
preference names will link to the system preferences page.

To test, apply the patch and log into the staff interface as a user with
permission to edit system preferences.

- Go to Serials -> New subscription.
- The "Number of issues to display to staff" field should have a hint
  under it: "Default: XX (StaffSerialIssueDisplayCount system
   preference)"
- The "Number of issues to display to the public" field should have a
  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
  preference)"
- Log out and log back in as a user who does not have permission to edit
  system preferences. Return to the form and confirm that the hints do
  not link to system preferences.

Comment 2 Owen Leonard 2022-05-12 16:27:12 UTC

*** Bug 26378 has been marked as a duplicate of this bug. ***

Comment 3 David Nind 2022-05-13 01:05:29 UTC Comment hidden (obsolete)

Created attachment 134940 [details] [review]
Bug 26549: Show value of global system preferences on subscription form

This patch modifies the subscription entry form so that the values of
two system preferences are displayed as a hint to the user:

The "Number of issues to display to staff" field will show the value
of the StaffSerialIssueDisplayCount preference, and the "Number of
issues to display to the public" field will show
OPACSerialIssueDisplayCount. If the user has permission the system
preference names will link to the system preferences page.

To test, apply the patch and log into the staff interface as a user with
permission to edit system preferences.

- Go to Serials -> New subscription.
- The "Number of issues to display to staff" field should have a hint
  under it: "Default: XX (StaffSerialIssueDisplayCount system
   preference)"
- The "Number of issues to display to the public" field should have a
  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
  preference)"
- Log out and log back in as a user who does not have permission to edit
  system preferences. Return to the form and confirm that the hints do
  not link to system preferences.

Signed-off-by: David Nind <david@davidnind.com>

Comment 4 Jonathan Druart 2022-05-18 13:30:23 UTC Comment hidden (obsolete)

Created attachment 135110 [details] [review]
Bug 26549: Show value of global system preferences on subscription form

This patch modifies the subscription entry form so that the values of
two system preferences are displayed as a hint to the user:

The "Number of issues to display to staff" field will show the value
of the StaffSerialIssueDisplayCount preference, and the "Number of
issues to display to the public" field will show
OPACSerialIssueDisplayCount. If the user has permission the system
preference names will link to the system preferences page.

To test, apply the patch and log into the staff interface as a user with
permission to edit system preferences.

- Go to Serials -> New subscription.
- The "Number of issues to display to staff" field should have a hint
  under it: "Default: XX (StaffSerialIssueDisplayCount system
   preference)"
- The "Number of issues to display to the public" field should have a
  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
  preference)"
- Log out and log back in as a user who does not have permission to edit
  system preferences. Return to the form and confirm that the hints do
  not link to system preferences.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 5 Tomás Cohen Arazi (tcohen) 2022-07-22 17:57:29 UTC

Please rebase.

Comment 6 Katrin Fischer 2022-07-24 22:05:14 UTC

Created attachment 138067 [details] [review]
Bug 26549: Show value of global system preferences on subscription form

This patch modifies the subscription entry form so that the values of
two system preferences are displayed as a hint to the user:

The "Number of issues to display to staff" field will show the value
of the StaffSerialIssueDisplayCount preference, and the "Number of
issues to display to the public" field will show
OPACSerialIssueDisplayCount. If the user has permission the system
preference names will link to the system preferences page.

To test, apply the patch and log into the staff interface as a user with
permission to edit system preferences.

- Go to Serials -> New subscription.
- The "Number of issues to display to staff" field should have a hint
  under it: "Default: XX (StaffSerialIssueDisplayCount system
   preference)"
- The "Number of issues to display to the public" field should have a
  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
  preference)"
- Log out and log back in as a user who does not have permission to edit
  system preferences. Return to the form and confirm that the hints do
  not link to system preferences.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 7 Katrin Fischer 2022-07-24 22:05:51 UTC

Rebased and tested.

Comment 8 Tomás Cohen Arazi (tcohen) 2022-07-25 14:33:34 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 9 Lucas Gass (lukeg) 2022-09-02 19:22:55 UTC

Enhancement will not be backported to 22.05.x series