Bug 26657

Summary: "Unlinked" output of LinkBibHeadingsToAuthorities is ambiguous
Product: Koha Reporter: David Cook <dcook>
Component: MARC Bibliographic data supportAssignee: David Cook <dcook>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: phil
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 26657: Differentiate between unlinked and not linked

Description David Cook 2020-10-12 00:07:17 UTC
LinkBibHeadingsToAuthorities reports "unlinked" if a $9 link is deleted and it reports "unlinked" if there is no $9 link.

Those are very different states. 

It looks like LinkBibHeadingsToAuthorities is used by C4::Biblio::BiblioAutoLink (which doesn't use the output), and it is used by misc/link_bibs_to_authorities.pl, which does render the output.
Comment 1 David Cook 2020-10-12 00:36:01 UTC
Created attachment 111464 [details] [review]
Bug 26657: Differentiate between unlinked and not linked

This patch differentiates between unlinked (a linkage is removed)
and not linked (there is no linkage) in the output of
LinkBibHeadingsToAuthorities.

Test plan:
0. Use koha-testing-docker
1. koha-shell -c "./misc/link_bibs_to_authorities.pl -l --test" kohadev
2. Note 436 bibs checked, 1315 headings linked, 678 headings not linked

(Previously, the "not linked" headings would have been under
 the "unlinked" category.)
Comment 2 David Cook 2020-12-23 04:47:02 UTC
I would love to see some love on this one, as it's actually quite a handy change for sysadmins.