Bug 26657 - "Unlinked" output of LinkBibHeadingsToAuthorities is ambiguous
Summary: "Unlinked" output of LinkBibHeadingsToAuthorities is ambiguous
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-12 00:07 UTC by David Cook
Modified: 2023-07-05 21:16 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26657: Differentiate between unlinked and not linked (3.56 KB, patch)
2020-10-12 00:36 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2020-10-12 00:07:17 UTC
LinkBibHeadingsToAuthorities reports "unlinked" if a $9 link is deleted and it reports "unlinked" if there is no $9 link.

Those are very different states. 

It looks like LinkBibHeadingsToAuthorities is used by C4::Biblio::BiblioAutoLink (which doesn't use the output), and it is used by misc/link_bibs_to_authorities.pl, which does render the output.
Comment 1 David Cook 2020-10-12 00:36:01 UTC
Created attachment 111464 [details] [review]
Bug 26657: Differentiate between unlinked and not linked

This patch differentiates between unlinked (a linkage is removed)
and not linked (there is no linkage) in the output of
LinkBibHeadingsToAuthorities.

Test plan:
0. Use koha-testing-docker
1. koha-shell -c "./misc/link_bibs_to_authorities.pl -l --test" kohadev
2. Note 436 bibs checked, 1315 headings linked, 678 headings not linked

(Previously, the "not linked" headings would have been under
 the "unlinked" category.)
Comment 2 David Cook 2020-12-23 04:47:02 UTC
I would love to see some love on this one, as it's actually quite a handy change for sysadmins.