Description
Martin Renvoize
2020-10-16 06:03:42 UTC
This would also be helpful for folks who bookmark reports as a bookmark currently shows like this in my version of Koha: Koha › Reports › Guided reports wizard › Saved reports › GHW - BORROWERS - 'VAL' borrowers with outstanding fines/fees Report It can be edited as a bookmark (and part of it is a very long report title) but being able to strip out some of that breadcrumb and/or have the more generic parts at the end would be helpful for some staff. Lisette Sounds reasonable to me, Martin I like this idea; thanks for the bug, Martin. *** Bug 27743 has been marked as a duplicate of this bug. *** (In reply to wainuiwitikapark from bug #27743 comment #0) > Koha has good and descriptive page titles, but according to > https://www.w3.org/WAI/tips/writing/ the unique information should be first, > before the name of the website (Koha). Interesting, I wasn't aware there was an accessibility guideline around this too.. that adds weight to this bug even more, thanks for drawing attention to it. I'm going to add an item to the next development meeting to get a guideline drawn up so we can start working on this without risking new cases being introduced :) Hi everyone! Thanks for that Martin! As I've already been working on reversing the contents of the page title, I will just finish up the patch and attach it. Then it should hopefully be a lot easier when reconstructing it to have less information in it, which could be a follow up patch. Sounds great, I'm sure it'll be a great patch, thanks for working on it. I'm sure we'll all agree to set a guideline by it at the Dev meeting which should mean we keep up the good work going forward :) Created attachment 117894 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the modules folder and the modules/acqui folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the modules folder and the modules/acqui folderare swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117895 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the admin folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the admin folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117896 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the authorities folder, basket folder and batch folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the authorities, basket and batch folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117897 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the catalogue folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the catalogue folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117898 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the cataloguing folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the cataloguing folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117899 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the circ folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the circ folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117900 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the clubs folder, common folder and course_reserves folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the clubs, common and course_reserves folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117901 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the errors folder, ill folder and installer folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the errors, ill and installer folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117902 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the labels folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the labels folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117903 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the members folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the members folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117904 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the offline_circ folder and onboarding folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the offline_circ and onboarding folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117905 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the patroncards folder and patron_lists folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the patroncards and patron_lists folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117906 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the plugins folder and pos folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the plugins and pos folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117907 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the reports folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reports folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117908 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the reserve folder, reviews folder and rotating_collections folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reserve, reviews and rotating_collections folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117909 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the serials folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the serials folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117910 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the suggestion and tags folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the suggestions and tags folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117911 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the tools folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the tools folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117912 [details] [review] Bug 26703: changed page titles - unique info first This patch includes files in the virtualshelves folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the virtualshelves folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Hmm, something funny is going on here. It looks to me like lots patches, but each one has the same commit title and as such git bz has replaced the previous versions as opposed to attached them all as current. Perhaps try a rebase on your branch and add the directory you went through for each patch to the commit title? so Bug 26704: Changes page titles, unique info first - /admin Or something along those lines to prevent bugzilla confusing them? (In reply to Martin Renvoize from comment #27) > Hmm, something funny is going on here. > > It looks to me like lots patches, but each one has the same commit title and > as such git bz has replaced the previous versions as opposed to attached > them all as current. > > Perhaps try a rebase on your branch and add the directory you went through > for each patch to the commit title? > > so > > Bug 26704: Changes page titles, unique info first - /admin Oh my goodness, silly me! Thank you and will get on to that soon. Created attachment 117997 [details] [review] Bug 26703: modules and modules/acqui folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the modules folder and the modules/acqui folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117998 [details] [review] Bug 26703: admin folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the admin folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 117999 [details] [review] Bug 26703: authorities, basket and batch folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the authorities, basket and batch folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118000 [details] [review] Bug 26703: catalogue folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the catalogue folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118001 [details] [review] Bug 26703: cataloguing folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the cataloguing folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118002 [details] [review] Bug 26703: circ folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the circ folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118003 [details] [review] Bug 26703: clubs, common & course_reserves folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the clubs, common and course_reserves folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118004 [details] [review] Bug 26703: errors, ill and installer folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the errors, ill and installer folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118005 [details] [review] Bug 26703: labels folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the labels folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118006 [details] [review] Bug 26703: members folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the members folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118007 [details] [review] Bug 26703: offline_circ and onboarding folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the offline_circ and onboarding folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118008 [details] [review] Bug 26703: patroncards and patron_lists folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the patroncards and patron_lists folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118009 [details] [review] Bug 26703: plugins and pos folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the plugins and pos folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118010 [details] [review] Bug 26703: reports folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reports folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118011 [details] [review] Bug 26703: reserve, reviews & rotating_collections folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reserve, reviews and rotating_collections folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118012 [details] [review] Bug 26703: serials folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the serials folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118013 [details] [review] Bug 26703: suggestion and tags folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the suggestion and tags folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118014 [details] [review] Bug 26703: tools folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the tools folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Created attachment 118015 [details] [review] Bug 26703: virtualshelves folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the virtualshelves folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT (In reply to Martin Renvoize from comment #27) > Hmm, something funny is going on here. > > It looks to me like lots patches, but each one has the same commit title and > as such git bz has replaced the previous versions as opposed to attached > them all as current. > > Perhaps try a rebase on your branch and add the directory you went through > for each patch to the commit title? > > so > > Bug 26704: Changes page titles, unique info first - /admin All done! Thanks again Nice one.. I'll get to testing asap Created attachment 118034 [details] [review] Bug 26703: modules and modules/acqui folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the modules folder and the modules/acqui folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118035 [details] [review] Bug 26703: admin folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the admin folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118036 [details] [review] Bug 26703: authorities, basket and batch folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the authorities, basket and batch folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118037 [details] [review] Bug 26703: catalogue folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the catalogue folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118038 [details] [review] Bug 26703: cataloguing folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the cataloguing folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118039 [details] [review] Bug 26703: circ folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the circ folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118040 [details] [review] Bug 26703: clubs, common & course_reserves folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the clubs, common and course_reserves folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118041 [details] [review] Bug 26703: errors, ill and installer folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the errors, ill and installer folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118042 [details] [review] Bug 26703: labels folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the labels folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118043 [details] [review] Bug 26703: members folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the members folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118044 [details] [review] Bug 26703: offline_circ and onboarding folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the offline_circ and onboarding folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118045 [details] [review] Bug 26703: patroncards and patron_lists folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the patroncards and patron_lists folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118046 [details] [review] Bug 26703: plugins and pos folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the plugins and pos folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118047 [details] [review] Bug 26703: reports folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reports folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118048 [details] [review] Bug 26703: reserve, reviews & rotating_collections folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reserve, reviews and rotating_collections folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118049 [details] [review] Bug 26703: serials folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the serials folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118050 [details] [review] Bug 26703: suggestion and tags folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the suggestion and tags folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118051 [details] [review] Bug 26703: tools folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the tools folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118052 [details] [review] Bug 26703: virtualshelves folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the virtualshelves folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 118053 [details] [review] Bug 26703: (follow-up) Reverse title for mana report search results Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is looking great.. singing off! The new guideline is ready for review.. I've kept it deliberately sparse for now focusing only on the 'Unique element first' aspect.. we can add the '70 character only' best practice later if we want to: https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC3:_Title_elements_should_contain_unique_information_information_first (In reply to Martin Renvoize from comment #71) > This is looking great.. singing off! Awesome! Thanks heaps!! (In reply to Martin Renvoize from comment #72) > The new guideline is ready for review.. I've kept it deliberately sparse for > now focusing only on the 'Unique element first' aspect.. we can add the '70 > character only' best practice later if we want to: > > https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC3: > _Title_elements_should_contain_unique_information_information_first Thanks! That looks great! Hmm, I didn't expect this to sit so long after my SO... if anyone wants to test this then we could convert my SO to a QA stamp.. I'd like for that second set of eyes to make sure I've not missed anything, but in general, the coding is all sound in my opinion.. it just needs a final check to make sure no cases are missed. I'll have a go at testing. Created attachment 119652 [details] [review] Bug 26703: modules and modules/acqui folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the modules folder and the modules/acqui folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119653 [details] [review] Bug 26703: admin folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the admin folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119654 [details] [review] Bug 26703: authorities, basket and batch folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the authorities, basket and batch folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119655 [details] [review] Bug 26703: catalogue folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the catalogue folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119656 [details] [review] Bug 26703: cataloguing folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the cataloguing folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119657 [details] [review] Bug 26703: circ folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the circ folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119658 [details] [review] Bug 26703: clubs, common & course_reserves folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the clubs, common and course_reserves folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119659 [details] [review] Bug 26703: errors, ill and installer folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the errors, ill and installer folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119660 [details] [review] Bug 26703: labels folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the labels folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119661 [details] [review] Bug 26703: members folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the members folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119662 [details] [review] Bug 26703: offline_circ and onboarding folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the offline_circ and onboarding folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119663 [details] [review] Bug 26703: patroncards and patron_lists folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the patroncards and patron_lists folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119664 [details] [review] Bug 26703: plugins and pos folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the plugins and pos folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119665 [details] [review] Bug 26703: reports folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reports folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119666 [details] [review] Bug 26703: reserve, reviews & rotating_collections folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reserve, reviews and rotating_collections folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119667 [details] [review] Bug 26703: serials folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the serials folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119668 [details] [review] Bug 26703: suggestion and tags folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the suggestion and tags folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119669 [details] [review] Bug 26703: tools folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the tools folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119670 [details] [review] Bug 26703: virtualshelves folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the virtualshelves folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 119671 [details] [review] Bug 26703: (follow-up) Reverse title for mana report search results Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Rebased for bugs 28037 and 27846 which have both now been pushed to master. Wainui and Martin, most of these all look great but I think there are two minor outstanding issues: 1) I'm getting an error page when I click on Budgets or Funds (koha/admin/aqbudgets.pl) This is the error message: "Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt line 8: unexpected token (END) [% END %] at /kohadevbox/koha/C4/Templates.pm line 122" I think there's something wrong with the title field in aqbudgets.tt: <title>[% IF ( budget_id ) %]Modify fund[% IF ( budget_name ) %] '[% budget_name | html %]'[% END %][% ELSE %]Add fund [% END %][ % END %] › Funds[% IF op == 'add_form' %] › Administration › Koha</title> Should it look something like this instead? <title>[% IF op == 'add_form' %][% IF ( budget_id ) %]Modify fund[% IF ( budget_name ) %] '[% budget_name | html %]'[% END %][% ELSE %]Add fund[% END %][% END %]› Funds › Administration › Koha</title> 2) There's a typo in the the currency.pl title I think it should be "Currencies › Currencies & Exchange rates › Administration › Koha" rather than "Currencies › Exchange rates › Currencies & Administration › Koha" Created attachment 119820 [details] [review] Bug 26703: (follow-up) corrected aqbudgets title Corrected the admin/aqbudgets file so that the page title displays correctly. To test: 1) Go to staff client 2) Go to admins module 3) Go to aqbudgets page 4) Check that the page title is "Funds > Administration > Koha" 5) Check that when modifying a fund the page title is "Modify Fund > Funds > Administration > Koha" or "Modify Fund [Fund Name] > Funds > Administration > Koha" 6) Check that when adding a fund the page title is "Add Fund > Funds > Administration > Koha" Sponsored-by: Catalyst IT Created attachment 119824 [details] [review] Bug 26703: (follow-up) corrected currencies title Corrected the page title in the admin/currency file. To test: 1) Go to staff client 2) Go to admin/currency 3) Check that the page title is "Currencies > Currencies & Exchange rates > Administration > Koha" 4) Check that when adding a currency, the page title is "New currency > Currencies & Exchange rates > Administration > Koha" 5) Check that when modifying a currency, the page title is "Modify currency '[Currency name]' > Currencies & Exchange rates > Administration > Koha" 6) Check that when deleting a currency, the page title is "Confirm deletion of currency '[Currency name]' > Currencies & Exchange rates > Administration > Koha" Sponsored-by: Catalyst IT (In reply to Henry Bolshaw from comment #98) > Wainui and Martin, most of these all look great but I think there are two > minor outstanding issues: > > 1) I'm getting an error page when I click on Budgets or Funds > (koha/admin/aqbudgets.pl) > > This is the error message: > > "Template process failed: file error - parse error - > /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt > line 8: unexpected token (END) > [% END %] at /kohadevbox/koha/C4/Templates.pm line 122" > > I think there's something wrong with the title field in aqbudgets.tt: > > <title>[% IF ( budget_id ) %]Modify fund[% IF ( budget_name ) %] '[% > budget_name | html %]'[% END %][% ELSE %]Add fund [% END %][ % END %] > › Funds[% IF op == 'add_form' %] › Administration › > Koha</title> > > Should it look something like this instead? > > <title>[% IF op == 'add_form' %][% IF ( budget_id ) %]Modify fund[% IF ( > budget_name ) %] '[% budget_name | html %]'[% END %][% ELSE %]Add fund[% END > %][% END %]› Funds › Administration › Koha</title> > > 2) There's a typo in the the currency.pl title > > I think it should be "Currencies › Currencies & Exchange rates › > Administration › Koha" rather than > "Currencies › Exchange rates › Currencies & Administration › Koha" Hi Henry! Thanks so much for pointing these out. I have added 2 follow-up patches to correct these. Created attachment 119873 [details] [review] Bug 26703: modules and modules/acqui folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the modules folder and the modules/acqui folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119874 [details] [review] Bug 26703: admin folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the admin folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119875 [details] [review] Bug 26703: authorities, basket and batch folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the authorities, basket and batch folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119876 [details] [review] Bug 26703: catalogue folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the catalogue folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119877 [details] [review] Bug 26703: cataloguing folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the cataloguing folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119878 [details] [review] Bug 26703: circ folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the circ folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119879 [details] [review] Bug 26703: clubs, common & course_reserves folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the clubs, common and course_reserves folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119880 [details] [review] Bug 26703: errors, ill and installer folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the errors, ill and installer folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119881 [details] [review] Bug 26703: labels folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the labels folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119882 [details] [review] Bug 26703: members folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the members folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119883 [details] [review] Bug 26703: offline_circ and onboarding folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the offline_circ and onboarding folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119884 [details] [review] Bug 26703: patroncards and patron_lists folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the patroncards and patron_lists folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119885 [details] [review] Bug 26703: plugins and pos folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the plugins and pos folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119886 [details] [review] Bug 26703: reports folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reports folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119887 [details] [review] Bug 26703: reserve, reviews & rotating_collections folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the reserve, reviews and rotating_collections folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119888 [details] [review] Bug 26703: serials folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the serials folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119889 [details] [review] Bug 26703: suggestion and tags folders Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the suggestion and tags folders are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119890 [details] [review] Bug 26703: tools folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the tools folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119891 [details] [review] Bug 26703: virtualshelves folder Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Ensure each of the files in the virtualshelves folder are swapped around to display the most unique information first, and the website name is at the end 3) Ensure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119892 [details] [review] Bug 26703: (follow-up) Reverse title for mana report search results Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119893 [details] [review] Bug 26703: (follow-up) corrected aqbudgets title Corrected the admin/aqbudgets file so that the page title displays correctly. To test: 1) Go to staff client 2) Go to admins module 3) Go to aqbudgets page 4) Check that the page title is "Funds > Administration > Koha" 5) Check that when modifying a fund the page title is "Modify Fund > Funds > Administration > Koha" or "Modify Fund [Fund Name] > Funds > Administration > Koha" 6) Check that when adding a fund the page title is "Add Fund > Funds > Administration > Koha" Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119894 [details] [review] Bug 26703: (follow-up) corrected currencies title Corrected the page title in the admin/currency file. To test: 1) Go to staff client 2) Go to admin/currency 3) Check that the page title is "Currencies > Currencies & Exchange rates > Administration > Koha" 4) Check that when adding a currency, the page title is "New currency > Currencies & Exchange rates > Administration > Koha" 5) Check that when modifying a currency, the page title is "Modify currency '[Currency name]' > Currencies & Exchange rates > Administration > Koha" 6) Check that when deleting a currency, the page title is "Confirm deletion of currency '[Currency name]' > Currencies & Exchange rates > Administration > Koha" Sponsored-by: Catalyst IT Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Created attachment 119895 [details] [review] Bug 26703: (follow-up) remove starting separator from csv profiles title Rearranged the separators in the csv profiles page title to match other page title formats. To test: 1) Go to the staff client 2) Go to the CSV profiles page in the Tools module 3) Check that the page title is "CSV export profiles › Tools › Koha" 4) Check that the page title when adding a new profile is "New CSV profile › CSV export profiles › Tools › Koha" 5) Check that the page title when editing a profile is "Modify a CSV profile › CSV export profiles › Tools › Koha" Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Hi Wainui and Martin, I've signed off all of the patches now. (Great work Wainui! The testing took a long time so I can only imagine how long it took to fix everything!) I noticed that there was an extra '›' at the start of the CSV profiles page title so I've added a trivial follow up patch to fix that. I've left the status at needs signoff because that patch hasn't been checked. Created attachment 119897 [details] [review] Bug 26703: (follow-up) remove starting separator from csv profiles title Rearranged the separators in the csv profiles page title to match other page title formats. To test: 1) Go to the staff client 2) Go to the CSV profiles page in the Tools module 3) Check that the page title is "CSV export profiles › Tools › Koha" 4) Check that the page title when adding a new profile is "New CSV profile › CSV export profiles › Tools › Koha" 5) Check that the page title when editing a profile is "Modify a CSV profile › CSV export profiles › Tools › Koha" Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> (In reply to Henry Bolshaw from comment #125) > Hi Wainui and Martin, I've signed off all of the patches now. (Great work > Wainui! The testing took a long time so I can only imagine how long it took > to fix everything!) > > I noticed that there was an extra '›' at the start of the CSV profiles page > title so I've added a trivial follow up patch to fix that. I've left the > status at needs signoff because that patch hasn't been checked. Hi Henry! Thanks so much, that's awesome! I've signed off your patch, thanks heaps for that! I've given the whole patchset another run-through and am happy to call PQA on it.. Great teamwork at the end there fixing up the last few minor points. Thanks everyone. QA test added https://gitlab.com/koha-community/qa-test-tools/-/issues/50 commit 4fbb3e2389aef8d2adda943671500685d19309ea Issue #50 - Title elements must start with the unique information See bug 26703 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 This is not optimal as we won't catch: """ <title> Koha """ But it's a start What about those ones? koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt:<title>Koha › Administration › Library checkin and transfer policy</title> koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt:<title>Koha › koha-tmpl/intranet-tmpl/prog/en/modules/circ/transfers_to_send.tt:<title>Koha › Circulation › Transfers to send</title> Created attachment 119940 [details] [review] Bug 26703: Fix selenium tests I will push the whole patch set, please follow-up here if you agree with comment 130. Pushed to master for 21.05, thanks to everybody involved! Created attachment 119982 [details] [review] Bug 26703: (follow-up) fixed some page titles in files Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Esnure each othe files auth.tt, admin/transfer_limits.tt and circ/transfers_to_send.tt have page titles that are swapped around to display the most unique information first, and the wensite name is at the end 3) Esnure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT (In reply to Jonathan Druart from comment #130) > What about those ones? > > koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt:<title>Koha > › Administration › Library checkin and transfer policy</title> > > > koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt:<title>Koha › > > koha-tmpl/intranet-tmpl/prog/en/modules/circ/transfers_to_send.tt: > <title>Koha › Circulation › Transfers to send</title> Hi Jonathan! Thanks so much for pointing these out, not sure how these were missed. I have added a follow-up patch to amend these. Created attachment 119983 [details] [review] Bug 26703: (follow-up) fixed some page titles in files Swapped the order of the page titles to have the unique information first, i.e. the name of the specific page displays first, and the name of the website (e.g. Koha) displays at the end. To test: 1) Apply patch 2) Esnure each othe files auth.tt, admin/transfer_limits.tt and circ/transfers_to_send.tt have page titles that are swapped around to display the most unique information first, and the wensite name is at the end 3) Esnure the pages displayed on the Staff Client that correspond to these files also display the changes Sponsored-by: Catalyst IT JD amended patch: remove dup "IP address change" Follow-up pushed to master, thanks Wainui! Enhancement not pushed to 20.11.x |