|
Description
Julian Maurice
2020-10-21 11:05:59 UTC
Created attachment 112093 [details] [review] Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Test plan: 1. Create a manual invoice for any patron and click on "Save and pay", you should be redirected to the payment form 2. Confirm the payment, make sure it appears in the transactions tab Created attachment 112313 [details] [review] Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 112351 [details] [review] Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> 1. Parameter needs to be URI escaped, at least the description 2. Why the sprintf? I am expecting the formatting to be template side? Failing QA for 1. Created attachment 120856 [details] [review] Bug 26760: Escape URI parameters in redirect URI to paycollect.pl Also remove useless '%.2f' formatting of amount and amountoutstanding (In reply to Jonathan Druart from comment #5) > 1. Parameter needs to be URI escaped, at least the description Fixed > 2. Why the sprintf? I am expecting the formatting to be template side? If you're talking about sprintf('%.2f', ...) I don't remember why I added this, and it seems useless, so I removed it. Created attachment 122577 [details] [review] Bug 26760: Redirect to paycollect.pl when clicking on "Save and pay" Bug 14898 added the "Save and pay" button that redirects to "Make a payment" tab after creating a manual invoice This requires the user to click on another "Pay" button before being taken to the real payment form. By redirecting directly to paycollect.pl, this useless step will no longer be needed. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 122578 [details] [review] Bug 26760: Escape URI parameters in redirect URI to paycollect.pl Also remove useless '%.2f' formatting of amount and amountoutstanding Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.02 I propose we do not impact older versions behavior. |