It's annoying to add a manual invoice and have to click on pay tab if you want to pay it immediately. This small patch could make much better user experience.
Created attachment 42872 [details] [review] Bug 14898: After adding manual invoice redirect to pay tab instead of account Test plan: 1) Create manual invoice for any patron,note you are redirected to Account tab 2) Apply the patch 3) Create manual invoice for any patron, you should be redirected to Pay tab
Created attachment 42896 [details] [review] [Signed-off] Bug 14898: After adding manual invoice redirect to pay tab instead of account Test plan: 1) Create manual invoice for any patron,note you are redirected to Account tab 2) Apply the patch 3) Create manual invoice for any patron, you should be redirected to Pay tab Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
I always thought it was a feature :) I agree with you, but maybe some others won't. Katrin, Kyle and Nicole, Can I get your point of view here please?
My feeling right now is that after adding a manual fine/fee we should remain on the tab for adding fines/fees... that seems most consistent to me - but I might be wrong :)
I'm actually okay either way. I know there are time when I don't want to leave the tab and others when I do - so it's really no big deal to me either way.
My two cents - since it is about fines and payment :-) Have two buttons for saving. - "Save" would behave as before. - Additional button "Save and pay" would redirect to payment. That would enhance user experience as proposed by Josef without changing behaviour users are used to. Marc
Marc's suggestion sounds like a good compromise :) Josef, do you agree?
I absolutely agree. I'll try to go this way.
Created attachment 98488 [details] [review] Bug 14898: Add button at manual invoice to redirect to pay tab Test plan: 1. Create manual invoice for any patron and click on "Save", you should be redirected to Account tab 2. Create manual invoice for any patron and click on "Save and pay", you should be redirected to Account tab
Created attachment 98610 [details] [review] Bug 14898: Add button at manual invoice to redirect to pay tab Test plan: 1. Create a manual invoice for any patron and click on "Save", you should be redirected to the Transactions tab (current behavour) 2. Create a manual invoice for any patron and click on "Save and pay", you should be redirected to Make a payment tab Signed-off-by: David Nind <david@davidnind.com>
Created attachment 99295 [details] [review] Bug 14898: Add button at manual invoice to redirect to pay tab Test plan: 1. Create manual invoice for any patron and click on "Save", you should be redirected to Account tab 2. Create manual invoice for any patron and click on "Save and pay", you should be redirected to Account tab Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Wow.. such a simple and nice little addition.. such a shame it took 5 years to work through the process :( Thanks for persevering
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x