Bug 26926

Summary: Omnibus: Update all occurrences of <input type="number"> to apply ACC2 coding guideline
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Eden <eden.bacani>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: aleisha, bolshawh, catherinem2003, david, eden.bacani, jonathan.druart
Version: MainKeywords: accessibility
Hardware: All   
OS: All   
URL: https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_.22number.22_should_be_avoided
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 27290, 27404, 27405, 27406, 27407, 27408, 27409, 27410, 27411, 27412, 28134, 28135, 28283    
Bug Blocks: 23003    

Description Martin Renvoize 2020-11-04 15:55:53 UTC
Retroactively apply ACC2 coding guideline

We need to update all `input type="number"` occurrences to use `<input type="text" inputmode="numeric" pattern="[0-9]*">` as per the new accessibility guideline.
Comment 1 Katrin Fischer 2021-01-11 22:12:35 UTC
This bug split into multiple might make a good Academy task?
Comment 2 Martin Renvoize 2021-01-12 10:27:03 UTC
(In reply to Katrin Fischer from comment #1)
> This bug split into multiple might make a good Academy task?

Done
Comment 4 David Nind 2021-02-20 23:14:59 UTC
Owen Leonard updated Bug 27408 and Bug 27410 for currency strings, and I've updated Bug 27405:

- inputmode changed to "decimal"
- regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt

"The regex validating the modified field doesn't allow for currency-formatted values like "1.00" because of the dot."
Comment 5 Henry Bolshaw 2021-04-12 09:48:12 UTC
I think all of these occurrences have been fixed now. Is that correct?
Comment 6 Owen Leonard 2021-04-12 11:39:49 UTC
(In reply to Henry Bolshaw from comment #5)
> I think all of these occurrences have been fixed now. Is that correct?

I think Bug 28134 and 28135 are the last.