Summary: | Advanced editor no longer selects newly created macros | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Cataloging | Assignee: | Phil Ringnalda <phil> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, david, fridolin.somers, m.de.rooy, nick, phil, victor |
Version: | 20.05 | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27890 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch fixes the behaviour for saving of new macros using the advanced editor. Before this fix the newly created macro wasn't selected and the automatic save (there isn't a save option) had nothing to save.
|
Version(s) released in: |
21.05.00,20.11.04,20.05.10
|
Circulation function: | |||
Bug Depends on: | 17268 | ||
Bug Blocks: | |||
Attachments: |
Bug 26964: Newly created macros should be selected in the Advanced editor
Bug 26964: Newly created macros should be selected in the Advanced editor Bug 26964: Newly created macros should be selected in the Advanced editor |
Description
Kelly McElligott
2020-11-07 18:56:21 UTC
Created attachment 117404 [details] [review] Bug 26964: Newly created macros should be selected in the Advanced editor The problem is that the newly created macro isn't selected, because the return values from the call to create it are accidentally thrown away. There isn't actually any option to save, just a timeout that automatically saves, but you can tell you are in this broken state because the Delete macro button is disabled. Test plan: 1. Prior to applying the patch, Administration - set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - Macros... - New macro... 3. Give it a name, click OK, notice that the Delete macro button is disabled 4. Apply patch, shift+reload 5. Macros... - New macro... 6. Give it a name, click OK, notice that the Delete macro button is enabled 7. Type something in the editor, delete 999 will do nicely, wait half a second to see Saved appear at the far right, close the macro popup 8. Macros..., click the name of your macro, verify it really was saved Created attachment 117405 [details] [review] Bug 26964: Newly created macros should be selected in the Advanced editor The problem is that the newly created macro isn't selected, because the return values from the call to create it are accidentally thrown away. There isn't actually any option to save, just a timeout that automatically saves, but you can tell you are in this broken state because the Delete macro button is disabled. Test plan: 1. Prior to applying the patch, Administration - set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - Macros... - New macro... 3. Give it a name, click OK, notice that the Delete macro button is disabled 4. Apply patch, shift+reload 5. Macros... - New macro... 6. Give it a name, click OK, notice that the Delete macro button is enabled 7. Type something in the editor, delete 999 will do nicely, wait half a second to see Saved appear at the far right, close the macro popup 8. Macros..., click the name of your macro, verify it really was saved Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Changed status to signed off - looks like Andrew signed off on 26 February 2021. Please change back if that is not the case. Oh, yes, thanks! I must have missed the status. This looks like a duplicate to bug 27890 and implements the same solution afaikt? *** Bug 27890 has been marked as a duplicate of this bug. *** Created attachment 117891 [details] [review] Bug 26964: Newly created macros should be selected in the Advanced editor The problem is that the newly created macro isn't selected, because the return values from the call to create it are accidentally thrown away. There isn't actually any option to save, just a timeout that automatically saves, but you can tell you are in this broken state because the Delete macro button is disabled. Test plan: 1. Prior to applying the patch, Administration - set the preference EnableAdvancedCatalogingEditor to Enable 2. Cataloging - Advanced editor - Macros... - New macro... 3. Give it a name, click OK, notice that the Delete macro button is disabled 4. Apply patch, shift+reload 5. Macros... - New macro... 6. Give it a name, click OK, notice that the Delete macro button is enabled 7. Type something in the editor, delete 999 will do nicely, wait half a second to see Saved appear at the far right, close the macro popup 8. Macros..., click the name of your macro, verify it really was saved Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.04 Pushed to 20.05.x for 20.05.10 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |