Bug 27890 - Advanced editor - new macro not selected after creation
Summary: Advanced editor - new macro not selected after creation
Status: RESOLVED DUPLICATE of bug 26964
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-06 15:37 UTC by Nick Clemens (kidclamp)
Modified: 2021-03-07 15:57 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 27890: Select new macro after creation (1.46 KB, patch)
2021-03-06 15:40 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 27890: Select new macro after creation (1.51 KB, patch)
2021-03-06 21:12 UTC, David Nind 		Details | Diff | Splinter Review
Bug 27890: Select new macro after creation (1.57 KB, patch)
2021-03-07 12:42 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2021-03-06 15:37:44 UTC 
When a new macro is created it is not automatically selected - if you edit without selecting the macro nothing will be saved
Comment 1 Nick Clemens (kidclamp) 2021-03-06 15:40:58 UTC 
Created attachment 117885 [details] [review]
Bug 27890: Select new macro after creation

There was an error here, we were capturing the status of the request (i.e. success)
instead of the returned data.

To test:
 1 - Go to Cataloguing -> Advanced editor
 2 - Click 'Macros'
 3 - 'New macro..'
 4 - Assing a name and click 'Ok'
 5 - New macro is in list on left, but not selected
 6 - Type into editor, no save feedback after typing
 7 - Apply patch
 8 - Reload the editor
 9 - Repeat 3-4
10 - New macro is selected
11 - Type into editor, save notification appears
Comment 2 David Nind 2021-03-06 21:12:37 UTC 
Created attachment 117888 [details] [review]
Bug 27890: Select new macro after creation

There was an error here, we were capturing the status of the request (i.e. success)
instead of the returned data.

To test:
 1 - Go to Cataloguing -> Advanced editor
 2 - Click 'Macros'
 3 - 'New macro..'
 4 - Assing a name and click 'Ok'
 5 - New macro is in list on left, but not selected
 6 - Type into editor, no save feedback after typing
 7 - Apply patch
 8 - Reload the editor
 9 - Repeat 3-4
10 - New macro is selected
11 - Type into editor, save notification appears

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2021-03-07 12:42:17 UTC 
This works, but it could be a nice addition to set the focus into the text field. At the moment you still have to click before you can typing the macro.
Comment 4 Katrin Fischer 2021-03-07 12:42:56 UTC 
Created attachment 117890 [details] [review]
Bug 27890: Select new macro after creation

There was an error here, we were capturing the status of the request (i.e. success)
instead of the returned data.

To test:
 1 - Go to Cataloguing -> Advanced editor
 2 - Click 'Macros'
 3 - 'New macro..'
 4 - Assing a name and click 'Ok'
 5 - New macro is in list on left, but not selected
 6 - Type into editor, no save feedback after typing
 7 - Apply patch
 8 - Reload the editor
 9 - Repeat 3-4
10 - New macro is selected
11 - Type into editor, save notification appears

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2021-03-07 15:57:44 UTC 
We have an identical patch on bug 26964 - I've decided to prefer the other :)

*** This bug has been marked as a duplicate of bug 26964 ***