Summary: | streetnumber field not shown in table when searching by partial patron data | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrewfh, gmcharlt, jonathan.druart, kyle.m.hall |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Bug 26965: Add streetnumber to the AJAX patron searches (ysearch.pl) |
Description
Christopher Brannon
2020-11-07 20:05:30 UTC
The (technical) problem is that the address is correctly formatted using a TT include file (member-display-address-style.inc) which is not available in JS. I can provide a patch but the "where do I place the streetnumber?" question will create a debate... Created attachment 113499 [details] [review] Bug 26965: Add streetnumber to the AJAX patron searches (ysearch.pl) Test plan: On the different places the patrons are retrieved using the ysearch.pl script (circ header, course reserves, article requests, place a hold), search for patrons and confirm that the streetnumber is now displayed before the address. Not considering this behaviour a major bug however, lowering severity. (In reply to Jonathan Druart from comment #1) > The (technical) problem is that the address is correctly formatted using a > TT include file (member-display-address-style.inc) which is not available in > JS. > > I can provide a patch but the "where do I place the streetnumber?" question > will create a debate... I don't know why it should be a debate. It is already placed in front of the addresses on all the patron account pages. (In reply to Jonathan Druart from comment #1) > The (technical) problem is that the address is correctly formatted using a > TT include file (member-display-address-style.inc) which is not available in > JS. > > I can provide a patch but the "where do I place the streetnumber?" question > will create a debate... I don't know why it should be a debate. It is already placed in front of the addresses on all the patron account pages. There is a syspref to change the way the addresses are displayed. However I've checked when I wrote the patch, the 3 versions has the street number before the "address" value (In reply to Jonathan Druart from comment #6) > There is a syspref to change the way the addresses are displayed. However > I've checked when I wrote the patch, the 3 versions has the street number > before the "address" value In German the streetnumber goes after the street. So I believe your first idea was right here and that it needs more thought. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc;h=f31f379d842a39401e579cc177db5406be76dd57;hb=64ee6f0b2bbcc9b23520c689146f1c5cf905e997#l29 I believe this one has been resolved by the changes to patron search. We no longer have said table. |