Bug 26965 - streetnumber field not shown in table when searching by partial patron data
Summary: streetnumber field not shown in table when searching by partial patron data
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-07 20:05 UTC by Christopher Brannon
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 26965: Add streetnumber to the AJAX patron searches (ysearch.pl) (5.65 KB, patch)
2020-11-11 14:13 UTC, Jonathan Druart 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2020-11-07 20:05:30 UTC 
The Patron selection table on circulation.pl displays the patron address, but does not include the streetnumber field.
Comment 1 Jonathan Druart 2020-11-11 14:08:42 UTC 
The (technical) problem is that the address is correctly formatted using a TT include file (member-display-address-style.inc) which is not available in JS.

I can provide a patch but the "where do I place the streetnumber?" question will create a debate...
Comment 2 Jonathan Druart 2020-11-11 14:13:30 UTC 
Created attachment 113499 [details] [review]
Bug 26965: Add streetnumber to the AJAX patron searches (ysearch.pl)

Test plan:
On the different places the patrons are retrieved using the ysearch.pl
script (circ header, course reserves, article requests, place a hold),
search for patrons and confirm that the streetnumber is now displayed
before the address.
Comment 3 Jonathan Druart 2020-11-11 14:13:59 UTC 
Not considering this behaviour a major bug however, lowering severity.
Comment 4 Christopher Brannon 2020-11-12 15:47:35 UTC 
(In reply to Jonathan Druart from comment #1)
> The (technical) problem is that the address is correctly formatted using a
> TT include file (member-display-address-style.inc) which is not available in
> JS.
> 
> I can provide a patch but the "where do I place the streetnumber?" question
> will create a debate...

I don't know why it should be a debate.  It is already placed in front of the addresses on all the patron account pages.
Comment 5 Christopher Brannon 2020-11-12 15:48:09 UTC 
(In reply to Jonathan Druart from comment #1)
> The (technical) problem is that the address is correctly formatted using a
> TT include file (member-display-address-style.inc) which is not available in
> JS.
> 
> I can provide a patch but the "where do I place the streetnumber?" question
> will create a debate...

I don't know why it should be a debate.  It is already placed in front of the addresses on all the patron account pages.
Comment 6 Jonathan Druart 2020-11-12 15:59:39 UTC 
There is a syspref to change the way the addresses are displayed. However I've checked when I wrote the patch, the 3 versions has the street number before the "address" value
Comment 7 Katrin Fischer 2020-11-12 20:37:30 UTC 
(In reply to Jonathan Druart from comment #6)
> There is a syspref to change the way the addresses are displayed. However
> I've checked when I wrote the patch, the 3 versions has the street number
> before the "address" value

In German the streetnumber goes after the street. So I believe your first idea was right here and that it needs more thought.

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc;h=f31f379d842a39401e579cc177db5406be76dd57;hb=64ee6f0b2bbcc9b23520c689146f1c5cf905e997#l29
Comment 8 Katrin Fischer 2023-02-26 12:19:46 UTC 
I believe this one has been resolved by the changes to patron search. We no longer have said table.