| Summary: | When renewalsallowed is empty the UI is not correct | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> | 
| Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> | 
| Status: | CLOSED FIXED | QA Contact: | Victor Grousset/tuxayo <victor> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, victor | 
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       21.05.00,20.11.01, 20.05.07 
 | 
        
        Circulation function: | |
| Attachments: | 
              Bug 26976: Display 0 if renewalsallowed is not defined
               Bug 26976: Display 0 if renewalsallowed is not defined Bug 26976: Display 0 if renewalsallowed is not defined  | 
      ||
| 
 
        
          Description
        
        
          Jonathan Druart
        
        
        
        
          2020-11-09 14:40:23 UTC
        
       
    Created attachment 113869 [details] [review] Bug 26976: Display 0 if renewalsallowed is not defined If the circulation rule "renewalsallowed" is not set (or an empty string) then the checkout list displays (0 of renewals remaining) It should display "0 of 0" Test plan: Set renewalsallowed to an empty string Check an item out Notice the change Created attachment 113883 [details] [review] Bug 26976: Display 0 if renewalsallowed is not defined If the circulation rule "renewalsallowed" is not set (or an empty string) then the checkout list displays (0 of renewals remaining) It should display "0 of 0" Test plan: Set renewalsallowed to an empty string Check an item out Notice the change Signed-off-by: David Nind <david@davidnind.com> Created attachment 114120 [details] [review] Bug 26976: Display 0 if renewalsallowed is not defined If the circulation rule "renewalsallowed" is not set (or an empty string) then the checkout list displays (0 of renewals remaining) It should display "0 of 0" Test plan: Set renewalsallowed to an empty string Check an item out Notice the change Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Pushed to master for 20.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.  |