Bug 27010

Summary: Warnings produced by Elasticsearch QueryBuilder.pm
Product: Koha Reporter: Joonas Kylmälä <joonas.kylmala>
Component: Searching - ElasticsearchAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact:
Severity: minor    
Priority: P5 - low CC: jonathan.druart
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 25790    

Description Joonas Kylmälä 2020-11-13 09:22:05 UTC
In Koha/SearchEngine/Elasticsearch/QueryBuilder.pm we get following warnings:

> [WARN] Use of uninitialized value $f in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605.
> [WARN] Use of uninitialized value $d in hash element at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 605.

This seems to be due to _convert_sort_fields() not checking whether my ( $f, $d ) get initialized by the regex before using them in the map function:

> 601     grep { $_->{field} } map {
> 602         my ( $f, $d ) = /(.+)_(.+)/;
> 603         {
> 604             field     => $sort_field_convert{$f},
> 605             direction => $sort_order_convert{$d}
> 606         }
Comment 1 Jonathan Druart 2020-12-01 14:03:13 UTC
From where do you get this warning?