Bug 25790 - [OMNIBUS] warnings removal
Summary: [OMNIBUS] warnings removal
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Andrew Nugged
QA Contact: Testopia
URL:
Keywords:
: 27126 (view as bug list)
Depends on: 8871 13344 14740 25533 27010 28228 29008 29410 29684 29898 29908 30196 30601 30638 30702 30703 30815 30816 31000 31125 25440 25491 25506 25695 25993 26590 27011 27161 27539 27548 27549 27745 27746 27861 28545 28776 29040 29452 29669 29687 29771 29883 30115 30366 30781 30788 30997 31001
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-17 21:09 UTC by Andrew Nugged
Modified: 2022-07-08 16:06 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Nugged 2020-06-17 21:09:02 UTC
This is an omnibus report to group tickets/tasks related to cleaning up of warnings, mostly now emitted in logs in various cases after "use warnings" added and also where something suspicious going on. Let's clean up our beautiful Universe from noise and potential bugs! <3 :P
Comment 1 Martin Renvoize 2020-06-25 13:51:22 UTC
Awesome to see such an effort being undertaken :)
Comment 2 Jonathan Druart 2020-12-01 14:13:13 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2022-02-10 15:22:02 UTC
Line number may vary:

Use of uninitialized value in string ne at /usr/share/koha/Koha/Item.pm line 169

         if (    exists $updated_columns{location}
-            and $self->location ne 'CART'
-            and $self->location ne 'PROC'
-            and $self->location ne 'MOVE' # RMA
+            and ( !defined($self->location) or $self->location !~ /^(CART|PROC)$/ )
             and not exists $updated_columns{permanent_location} )