| Summary: | Double permission check in svc/mana/search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Mana-kb | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | alex.arnaud, andrew, fridolin.somers, julian.maurice, victor |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06,20.05.12
|
|
| Circulation function: | |||
| Bug Depends on: | 17047 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 27061: Remove duplicate permission check in svc/mana/search
Bug 27061: Remove duplicate permission check in svc/mana/search Bug 27061: Remove duplicate permission check in svc/mana/search |
||
|
Description
Jonathan Druart
2020-11-20 08:03:03 UTC
Created attachment 113866 [details] [review] Bug 27061: Remove duplicate permission check in svc/mana/search There is a call to check_cookie_auth then another one to get_template_and_user Test plan: Use mana to create new report and new subscription. Confirm that you need the necessary permissions to use it Created attachment 119952 [details] [review] Bug 27061: Remove duplicate permission check in svc/mana/search There is a call to check_cookie_auth then another one to get_template_and_user Test plan: Use mana to create new report and new subscription. Confirm that you need the necessary permissions to use it Signed-off-by: Owen Leonard <oleonard@myacpl.org> This required a rebase so please check that I didn't do it incorrectly. Created attachment 120324 [details] [review] Bug 27061: Remove duplicate permission check in svc/mana/search There is a call to check_cookie_auth then another one to get_template_and_user Test plan: Use mana to create new report and new subscription. Confirm that you need the necessary permissions to use it Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Pushed to 20.05.x for 20.05.12 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |