Summary: | Stage for import button not showing up | ||
---|---|---|---|
Product: | Koha | Reporter: | Eric Bégin <eric.begin> |
Component: | MARC Bibliographic record staging/import | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, dcook, fridolin.somers, george, jonathan.druart, lucas, marjorie.barry-vila, mtj, oleonard, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.01,20.05.07,19.11.14
|
|
Circulation function: | |||
Attachments: |
Bug 27099: Stage for import button not showing up
Bug 27099: Stage for import button not showing up Bug 27099: Stage for import button not showing up |
Description
Eric Bégin
2020-11-25 21:37:58 UTC
It's working for me on master on both Firefox 68.12.0esr and Chromium 83.0.4103.116 We are having the same problem on Koha 19.05 and Chrome 87 for these pages: tools_batchMod-edit tools_stage-marc-import admin_preferences For admin_preferences the "Save all . . . preferences" buttons at the bottom of the page are covered by the language selector whenever the length of .col-sm-10.col-sm-push-2 is greater than the length of .col-sm-2.col-sm-pull-10 As far as I can tell, it's only happening on Chrome 87. I can't recreate the same problem on Firefox or older versions of Chrome. Confirmed on master with Chrome 87. Created attachment 114381 [details] [review] Bug 27099: Stage for import button not showing up In the latest version of Chrome, pages where the Humansmg library is included have a problem where the language footer obscures the bottom of the page. The problem traces back to some CSS in the Humanmsg library's CSS file: html, body { height: 100%; /* Damn you IE! */ } Removing the line doesn't have any ill effects that I can see in Chrome or Firefox, and it fixes the problem in Chrome. IE can be damned. To test you must have one or more translations enabled in the staff interface. - Apply the patch and clear your browser cache if necessary. - View pages in the staff interface which use the Humansmg library, e.g.: - Administration -> System preferences. Choose a category of preferences which will be numerous enough to require scrolling to reach the bottom of the page. - Tools -> Stage MARC records for import. Upload a file to display the form for staging the import. - Cataloging -> Advanced MARC editor On each page the language footer should not obscure the bottom of the page. Created attachment 114428 [details] [review] Bug 27099: Stage for import button not showing up In the latest version of Chrome, pages where the Humansmg library is included have a problem where the language footer obscures the bottom of the page. The problem traces back to some CSS in the Humanmsg library's CSS file: html, body { height: 100%; /* Damn you IE! */ } Removing the line doesn't have any ill effects that I can see in Chrome or Firefox, and it fixes the problem in Chrome. IE can be damned. To test you must have one or more translations enabled in the staff interface. - Apply the patch and clear your browser cache if necessary. - View pages in the staff interface which use the Humansmg library, e.g.: - Administration -> System preferences. Choose a category of preferences which will be numerous enough to require scrolling to reach the bottom of the page. - Tools -> Stage MARC records for import. Upload a file to display the form for staging the import. - Cataloging -> Advanced MARC editor On each page the language footer should not obscure the bottom of the page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thanks for this one, it has been troubling me lately as I could not recreate until I upgraded to Chrome 87. Created attachment 114571 [details] [review] Bug 27099: Stage for import button not showing up In the latest version of Chrome, pages where the Humansmg library is included have a problem where the language footer obscures the bottom of the page. The problem traces back to some CSS in the Humanmsg library's CSS file: html, body { height: 100%; /* Damn you IE! */ } Removing the line doesn't have any ill effects that I can see in Chrome or Firefox, and it fixes the problem in Chrome. IE can be damned. To test you must have one or more translations enabled in the staff interface. - Apply the patch and clear your browser cache if necessary. - View pages in the staff interface which use the Humansmg library, e.g.: - Administration -> System preferences. Choose a category of preferences which will be numerous enough to require scrolling to reach the bottom of the page. - Tools -> Stage MARC records for import. Upload a file to display the form for staging the import. - Cataloging -> Advanced MARC editor On each page the language footer should not obscure the bottom of the page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Pushed to 20.05.x for 20.05.07 Backported to 19.11.x branch for 19.11.14 |