|
Description
Séverine Queune
2020-12-01 09:32:21 UTC
Created attachment 131015 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Created attachment 131042 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Hi Jeremy, 0) Please assign yourself the bugs you plan to work on :) 1) QA test tools A good habit to start is to always run the QA test tools against your patches before submitting, so simple stuff doesn't get your patches sent back: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt FAIL filters missing_filter at line 265 ( [% patron_message.message %] <br>) FAIL tools/modborrowers.pl FAIL spelling bloc ==> block For adding the filter, this might be helpful in the future: misc/devel/add_missing_filters.pl 2) Code comments in English please :) + # Créer un bloc pour enregistrer en bdd l'update de la table patron_messages + sécurité : 'si' tel champ est remplit alors.... etc Can you please provide a follow-up and switch back to signed off? Created attachment 132923 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Created attachment 132924 [details] [review] Bug 27123: Add filter + translate comment Created attachment 132925 [details] [review] Bug 27123: whitespaces deleted Created attachment 132926 [details] [review] Bug 27123: Delete useless code Created attachment 132927 [details] [review] Bug 27123: Remove Dumpers I am sorry, Jérémy, this no longer applies. I fixed the first conflict, but got stuck on the second: Applying: Bug 27123: Add messages to batch patrons modification Applying: Bug 27123: whitespaces deleted Applying: Bug 27123: Delete useless code error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt). error: could not build fake ancestor Patch failed at 0001 Bug 27123: Delete useless code hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27123-Delete-useless-code-g_KXIH.patch Can you please rebase? Thanks Katrin for this, I fix it asap :) Created attachment 134065 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Hi Jérémy, is this ready for testing again? The sequence of patches doesn't appear to be right - or maybe some need to be obsoleted if you squashed? This would be a great addition to the patron batch modification tool. I notice that if you check the checkbox next to the message field ("Checking the box right next to the label will disable the entry and delete the values of that field on all selected patrons") it will delete *all* messages on that patron's account. I don't know if that was intentional? I can see it as being useful but also dangerous. At the very least we should add a hint about this behavior.
Created attachment 172012 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Signed-off-by: Heather Rommens <heather@bywatersolutions.com> Created attachment 172013 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Signed-off-by: Valerie Burnett <valerie@bywatersolutions.com> Created attachment 172053 [details] [review] Bug 27123: (follow-up) Add note to warn about removing all messages This patch adds a note to the batch patron modification form in order to warn the user about removing multiple messages at once. To test: - Apply the patch and go to Tools -> Batch patron modification - Enter or select multiple patrons and submit them for modification - On the page previewing the list patrons for modification, scroll down to the form. - Find the field for "Message" and confirm that there is a note next to the checkbox. Created attachment 172086 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Signed-off-by: Valerie Burnett <valerie@bywatersolutions.com> Signed-off-by: George Williams <george@nekls.org> Created attachment 172087 [details] [review] Bug 27123: (follow-up) Add note to warn about removing all messages This patch adds a note to the batch patron modification form in order to warn the user about removing multiple messages at once. To test: - Apply the patch and go to Tools -> Batch patron modification - Enter or select multiple patrons and submit them for modification - On the page previewing the list patrons for modification, scroll down to the form. - Find the field for "Message" and confirm that there is a note next to the checkbox. Signed-off-by: George Williams <george@nekls.org> Signed off a second time with followups - work per test plan Created attachment 172120 [details] [review] Bug 27123: Add messages to batch patrons modification With this patch you can write or delete circulation messages on the batch patrons modification form Test plan: 1)Go to Home > Tools > Batch patron modification 2)Write one or more card numbers to access the modification form 3)Notice the input you can interact with 4)Apply patch and repeat 1) & 2) 5)Notice the new input 'Message:' which appeared down the form 6)Write a message and choose a type (opac or intranet) 7)Save & notice the new 'Message' column filled up with what you wrote before 8)To delete: back on the modification form - check the checkbox beside the input - save again Signed-off-by: Valerie Burnett <valerie@bywatersolutions.com> Signed-off-by: George Williams <george@nekls.org> Created attachment 172121 [details] [review] Bug 27123: (follow-up) Add note to warn about removing all messages This patch adds a note to the batch patron modification form in order to warn the user about removing multiple messages at once. To test: - Apply the patch and go to Tools -> Batch patron modification - Enter or select multiple patrons and submit them for modification - On the page previewing the list patrons for modification, scroll down to the form. - Find the field for "Message" and confirm that there is a note next to the checkbox. Signed-off-by: George Williams <george@nekls.org> Created attachment 172122 [details] [review] Bug 27123: (QA follow-up) Tidy modborrowers.pl Nice team work all! Especially happy about this one since it's a rescue and also something we worked on at the hackfest in Montreal with lots of input all around. Pushed for 24.11! Well done everyone, thank you! Enhancement, no 24.05.x backport |