Summary: | Wrong display of messages if there was only 1 record modified | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Task Scheduler | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, fridolin.somers, lucas, victor |
Version: | unspecified | Keywords: | rel_20_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.01
|
|
Circulation function: | |||
Bug Depends on: | 22417 | ||
Bug Blocks: | 27317 | ||
Attachments: |
Bug 27127: Make Koha::BackgroundJob->messages return a scalar
Bug 27127: Make Koha::BackgroundJob->messages return a scalar Bug 27127: Make Koha::BackgroundJob->messages return a scalar |
Description
Jonathan Druart
2020-12-01 14:34:59 UTC
Created attachment 114073 [details] [review] Bug 27127: Make Koha::BackgroundJob->messages return a scalar Otherwise the code in the template is not handled correctly: 112 [% FOR m IN job.messages %] m will become each key/val of the message hash: {"type":"success","biblionumber":"1","code":"biblio_modified"} And not the whole hash Test plan: Modify one biblio using the batch record modification tool Modify two biblios using the batch record modification tool Go to the detail view of each job and confirm that with this patch the display is correct Without this patch the display is: https://snipboard.io/JKRlkU.jpg Created attachment 114162 [details] [review] Bug 27127: Make Koha::BackgroundJob->messages return a scalar Otherwise the code in the template is not handled correctly: 112 [% FOR m IN job.messages %] m will become each key/val of the message hash: {"type":"success","biblionumber":"1","code":"biblio_modified"} And not the whole hash Test plan: Modify one biblio using the batch record modification tool Modify two biblios using the batch record modification tool Go to the detail view of each job and confirm that with this patch the display is correct Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> The display for modifying 1 record looks much better now :) Created attachment 114491 [details] [review] Bug 27127: Make Koha::BackgroundJob->messages return a scalar Otherwise the code in the template is not handled correctly: 112 [% FOR m IN job.messages %] m will become each key/val of the message hash: {"type":"success","biblionumber":"1","code":"biblio_modified"} And not the whole hash Test plan: Modify one biblio using the batch record modification tool Modify two biblios using the batch record modification tool Go to the detail view of each job and confirm that with this patch the display is correct Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> all good :) Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Missing dependencies, not backported to 20.05 |