|
Description
Barbara Johnson
2020-12-11 21:41:53 UTC
Created attachment 114401 [details] [review] Bug 27212: Add Table configuration to acqui-home.pl accounts table Created attachment 114402 [details] [review] Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. There are probably some columns here that should not be able to be hidden and someone smarter than me can probably tell me which columns those are. Created attachment 114412 [details] [review] Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Lucas, this patch does seem to make some unexpected changes: 1) We have 2 new columns Budget period description and Active (with 1 and 0) visible, that have been hidden before and only used for sorting and other table functionality etc. 2) The totals are no longer being calculated at all. 3) QA script fails: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt OK filters FAIL forbidden patterns forbidden pattern: tab char (line 208) forbidden pattern: tab char (line 209) forbidden pattern: tab char (line 210) forbidden pattern: tab char (line 211) forbidden pattern: tab char (line 212) forbidden pattern: tab char (line 213) forbidden pattern: tab char (line 214) Created attachment 130128 [details] [review] Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. 6. Make sure the totals at the bottom of the screen can still be calculated Created attachment 130773 [details] [review] Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. 6. Make sure the totals at the bottom of the screen can still be calculated Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> This time around, No regressions found! Created attachment 132274 [details] [review] Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. 6. Make sure the totals at the bottom of the screen can still be calculated Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] This doesn't work for me. I tried on a bywater sandbox, just in case it was my installation that was the problem, and it's not working. Test plan : 1) Go to Acquisitions --> Notice the 'All available funds' table doesn't have a 'Columns' button 2) Go to Administration > Table settings > Acquisitions and find the accounts table 3) Check 'Is hidden by default' on 'owner' and 'library' 4) Click 'Save' 5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5) --> Notice the Owner and Library columns are still there (In reply to Caroline Cyr La Rose from comment #11) > This doesn't work for me. > > I tried on a bywater sandbox, just in case it was my installation that was > the problem, and it's not working. > > Test plan : > 1) Go to Acquisitions > --> Notice the 'All available funds' table doesn't have a 'Columns' button > 2) Go to Administration > Table settings > Acquisitions and find the > accounts table > 3) Check 'Is hidden by default' on 'owner' and 'library' > 4) Click 'Save' > 5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5) > --> Notice the Owner and Library columns are still there Hi Caroline, I saw the interaction in IRC earlier, but rule of thumb is never to reopen a bug that has been pushed and released - could you file a new bug instad and link them? We also need this to have proper release notes later for the fix. I opened bug 30938 and copy pasted my comment. Thanks for opening Bug 30938 Caroline. I am re-closing this one. |