The patch for bug 27212 doesn't work for me. I was told to open a new bug report. I tried on a bywater sandbox, just in case it was my installation that was the problem, and it's not working. Test plan : 1) Go to Acquisitions --> Notice the 'All available funds' table doesn't have a 'Columns' button 2) Go to Administration > Table settings > Acquisitions and find the accounts table 3) Check 'Is hidden by default' on 'owner' and 'library' 4) Click 'Save' 5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5) --> Notice the Owner and Library columns are still there
Created attachment 135956 [details] [review] Bug 30938: Convert ColumnSettings to TableSettings To test: 1. Apply this patch 2. Go to /cgi-bin/koha/acqui/acqui-home.pl 3. The columns button should be restored, make sure you can hide/show columns correctly. 4. Go to Table settings and make sure you can hide columns properly by default.
Created attachment 135977 [details] [review] Bug 30938: Convert ColumnSettings to TableSettings To test: 1. Apply this patch 2. Go to /cgi-bin/koha/acqui/acqui-home.pl 3. The columns button should be restored, make sure you can hide/show columns correctly. 4. Go to Table settings and make sure you can hide columns properly by default. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 136143 [details] [review] Bug 30938: Convert ColumnSettings to TableSettings To test: 1. Apply this patch 2. Go to /cgi-bin/koha/acqui/acqui-home.pl 3. The columns button should be restored, make sure you can hide/show columns correctly. 4. Go to Table settings and make sure you can hide columns properly by default. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix to rebase issue with first submission. Works as expected.. PQA
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.03
depends on 27212, not relevant to 21.11.x. Won't backport