Bug 30938 - Fix column configuration to the acquisitions home page
Summary: Fix column configuration to the acquisitions home page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 27212 29648
Blocks:
  Show dependency treegraph
 
Reported: 2022-06-09 19:40 UTC by Caroline Cyr La Rose
Modified: 2023-06-08 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the acquisitions home page to show the column configuration button.
Version(s) released in:
22.11.00, 22.05.03


Attachments
Bug 30938: Convert ColumnSettings to TableSettings (1.68 KB, patch)
2022-06-10 17:29 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 30938: Convert ColumnSettings to TableSettings (1.73 KB, patch)
2022-06-13 04:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 30938: Convert ColumnSettings to TableSettings (1.79 KB, patch)
2022-06-16 10:11 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2022-06-09 19:40:06 UTC
The patch for bug 27212 doesn't work for me. I was told to open a new bug report.

I tried on a bywater sandbox, just in case it was my installation that was the problem, and it's not working.

Test plan :
1) Go to Acquisitions
--> Notice the 'All available funds' table doesn't have a 'Columns' button
2) Go to Administration > Table settings > Acquisitions and find the accounts table
3) Check 'Is hidden by default' on 'owner' and 'library'
4) Click 'Save'
5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5)
--> Notice the Owner and Library columns are still there
Comment 1 Lucas Gass 2022-06-10 17:29:23 UTC
Created attachment 135956 [details] [review]
Bug 30938: Convert ColumnSettings to TableSettings

To test:
1. Apply this patch
2. Go to /cgi-bin/koha/acqui/acqui-home.pl
3. The columns button should be restored, make sure you can hide/show columns correctly.
4. Go to Table settings and make sure you can hide columns properly by default.
Comment 2 David Nind 2022-06-13 04:39:34 UTC
Created attachment 135977 [details] [review]
Bug 30938: Convert ColumnSettings to TableSettings

To test:
1. Apply this patch
2. Go to /cgi-bin/koha/acqui/acqui-home.pl
3. The columns button should be restored, make sure you can hide/show columns correctly.
4. Go to Table settings and make sure you can hide columns properly by default.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2022-06-16 10:11:55 UTC
Created attachment 136143 [details] [review]
Bug 30938: Convert ColumnSettings to TableSettings

To test:
1. Apply this patch
2. Go to /cgi-bin/koha/acqui/acqui-home.pl
3. The columns button should be restored, make sure you can hide/show columns correctly.
4. Go to Table settings and make sure you can hide columns properly by default.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2022-06-16 10:12:22 UTC
Trivial fix to rebase issue with first submission.  Works as expected..

PQA
Comment 5 Tomás Cohen Arazi 2022-06-17 13:30:03 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-07-13 20:30:09 UTC
Backported to 22.05.x for 22.05.03
Comment 7 Arthur Suzuki 2022-07-21 13:43:38 UTC
depends on 27212, not relevant to 21.11.x.
Won't backport