Summary: | Queued vs Enqueued | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | James O'Keeffe <jamespfk> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrewfh, fridolin.somers, jamespfk, julian.maurice |
Version: | unspecified | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06
|
|
Bug Depends on: | 27109 | ||
Bug Blocks: | 28149 | ||
Attachments: |
Bug 27277: Replace 'Enqueued' with 'Queue'
Bug 27277: Queued Vs Enqueued Bug 27277: Queued vs Enqueued Bug 27277: Queued Vs Enqueued Bug 27277: Queued vs Enqueued Bug 27277: Queued Vs Enqueued Bug 27277: Queued vs Enqueued |
Description
Jonathan Druart
2020-12-18 09:19:50 UTC
Created attachment 114511 [details] [review] Bug 27277: Replace 'Enqueued' with 'Queue' (In reply to Jonathan Druart from comment #0) > Should it be "Queued on" or "Queued at"? I agree with the change to "Queued" and I think we should drop the "on" altogether. Instead of "Queued on," "Started on," and "Ended on" we should use "Queued," "Started," and "Ended." Created attachment 115284 [details] [review] Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. Hi James, thanks for your patch! There are other occurrences to fix in the same file: 152 <th>Enqueued on</th> 153 <th>Started on</th> 154 <th>Ended on</th> Created attachment 115352 [details] [review] Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. Created attachment 119595 [details] [review] Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 119596 [details] [review] Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 119736 [details] [review] Bug 27277: Queued Vs Enqueued This patch changes "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" respectively on the bacground jobs page. Task plan: 1. Navigate to the background jobs page 2. Ensure the spelling change, and that the spelling is correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 119737 [details] [review] Bug 27277: Queued vs Enqueued Changed the other occurences of "Enqueued on", "Started on", and "Ended on" to "Queued", "Started", and "Ended" (As pointed out by Jonathan). Task Plan: 1. Navigate to th background jobs page 2. Ensure that the spelling of the changes are correct, and that there are no other instances of "Enqueued on", "Started on", and "Ended on" that have been missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Doesn't apply cleanly to 20.05, please rebase if needed |