Summary: | "Checked out by" not populated on issuehistory.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Séverine Queune <severine.queune> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, gmcharlt, jonathan.druart, kyle.m.hall, kyle, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00
|
Circulation function: | |
Bug Depends on: | 23916 | ||
Bug Blocks: | |||
Attachments: |
Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history"
Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" |
Description
Séverine Queune
2020-12-18 14:22:46 UTC
I believe this will only be available for checkouts after this was turned on (the data is not recorded before). Would you mind testing if that was the issue? I've tested this on a sandbox (current version, 21.06) and on our test server (20.11), and the error is valid on both. The setting is turned on. The checked out by information correctly populates in the patron's circulation history, but not in the item checkout history: /cgi-bin/koha/catalogue/issuehistory.pl Can confirm this issue exists in 21.05. I performed a checkout AFTER turning on the syspref. I see "Checked out by" in the patron history but not the item history. Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] Created attachment 125048 [details] [review] Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] It must have been patron=checkout.issuer as patron-title.inc is expecting a Koha::Patron object, not a borrowernumber. Test plan: Turn RecordStaffUserOnCheckout on Check an item out then in Go to the biblio checkout history and confirm that the "Checked out by" column contains the logged in librarian's name. Created attachment 125056 [details] [review] Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] It must have been patron=checkout.issuer as patron-title.inc is expecting a Koha::Patron object, not a borrowernumber. Test plan: Turn RecordStaffUserOnCheckout on Check an item out then in Go to the biblio checkout history and confirm that the "Checked out by" column contains the logged in librarian's name. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Very minor quibble, in patron circ history we only show first and last name of the person who did the checkout. In the bib's checkout history we're now showing first name, last name, and cardnumber. Didn't seem worth holding up a signoff. Created attachment 125330 [details] [review] Bug 27279: (bug 23916 follow-up) Fix issuer display on "Checkout history" Caused by commit 61a39b0dd52df4f6d743671823449e265d6add26 Bug 23916: (QA follow-up) Adapt all the things to the new column and accessor names - [% INCLUDE 'patron-title.inc' patron=checkout.issued_by %] + [% INCLUDE 'patron-title.inc' patron=checkout.issuer_id %] It must have been patron=checkout.issuer as patron-title.inc is expecting a Koha::Patron object, not a borrowernumber. Test plan: Turn RecordStaffUserOnCheckout on Check an item out then in Go to the biblio checkout history and confirm that the "Checked out by" column contains the logged in librarian's name. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.11, thanks to everybody involved! |