Bug 27317

Summary: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Test SuiteAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: andrewfh, caroline.cyr-la-rose, jonathan.druart, tomascohen, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.05.00,20.11.01
Bug Depends on: 27127    
Bug Blocks:    
Attachments: Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t

Description Fridolin Somers 2020-12-30 14:06:29 UTC
Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated
Comment 1 Fridolin Somers 2020-12-30 14:09:28 UTC
Created attachment 114744 [details] [review]
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t

Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated

Test plan :
prove t/db_dependent/Koha/BackgroundJobs.t
Comment 2 Tomás Cohen Arazi 2020-12-30 14:43:04 UTC
Created attachment 114745 [details] [review]
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t

Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated

Test plan :
prove t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: I fixed the indentation of the test label.
Comment 3 Victor Grousset/tuxayo 2020-12-30 14:52:21 UTC
Created attachment 114746 [details] [review]
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t

Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated

Test plan :
prove t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: I fixed the indentation of the test label.
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Tomás Cohen Arazi 2020-12-30 15:07:05 UTC
Pushed, to end the year with happy Jenkins.

Thanks everyone!
Comment 5 Fridolin Somers 2021-01-05 08:42:15 UTC
Pushed to 20.11.x for 20.11.01
Comment 6 Andrew Fuerste-Henry 2021-01-05 14:20:56 UTC
Missing dependencies for 20.05, not backporting.