Summary: | Don't hide the SMTP servers table when last displayed is deleted | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrewfh, caroline.cyr-la-rose, fridolin.somers, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.02
|
|
Bug Depends on: | 22343 | ||
Bug Blocks: | |||
Attachments: |
Bug 27356: Don't hide the SMTP servers table when last displayed is deleted
Bug 27356: Don't hide the SMTP servers table when last displayed is deleted Bug 27356: Don't hide the SMTP servers table when last displayed is deleted |
Description
Jonathan Druart
2021-01-07 10:13:44 UTC
Created attachment 114904 [details] [review] Bug 27356: Don't hide the SMTP servers table when last displayed is deleted Found on bug 27251 which was mimicking SMTP server code for QOTD. To recreate: Create a SMTP server with name "a" Create a SMTP server with name "aa" Filter by "aa" => Only 1 row displayed Delete it, confirm => The table disappears Note that we could re-add this test when bug 27353 will be pushed, as recordsTotal will contain the unfiltered number of records in the DB. Created attachment 114948 [details] [review] Bug 27356: Don't hide the SMTP servers table when last displayed is deleted Found on bug 27251 which was mimicking SMTP server code for QOTD. To recreate: Create a SMTP server with name "a" Create a SMTP server with name "aa" Filter by "aa" => Only 1 row displayed Delete it, confirm => The table disappears Note that we could re-add this test when bug 27353 will be pushed, as recordsTotal will contain the unfiltered number of records in the DB. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> BTW : "Default configuration" message is quite big. We may move it to a button opening a modal popup ? (In reply to Fridolin Somers from comment #3) > BTW : > "Default configuration" message is quite big. > We may move it to a button opening a modal popup ? That's a good idea. Created attachment 115000 [details] [review] Bug 27356: Don't hide the SMTP servers table when last displayed is deleted Found on bug 27251 which was mimicking SMTP server code for QOTD. To recreate: Create a SMTP server with name "a" Create a SMTP server with name "aa" Filter by "aa" => Only 1 row displayed Delete it, confirm => The table disappears Note that we could re-add this test when bug 27353 will be pushed, as recordsTotal will contain the unfiltered number of records in the DB. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.02 Missing dependencies, not backported to 20.05 |