Found on bug 27251 which was mimicking SMTP server code for QOTD. To recreate: Create a SMTP server with name "a" Create a SMTP server with name "aa" Filter by "aa" => Only 1 row displayed Delete it, confirm => The table disappears
Created attachment 114904 [details] [review] Bug 27356: Don't hide the SMTP servers table when last displayed is deleted Found on bug 27251 which was mimicking SMTP server code for QOTD. To recreate: Create a SMTP server with name "a" Create a SMTP server with name "aa" Filter by "aa" => Only 1 row displayed Delete it, confirm => The table disappears Note that we could re-add this test when bug 27353 will be pushed, as recordsTotal will contain the unfiltered number of records in the DB.
Created attachment 114948 [details] [review] Bug 27356: Don't hide the SMTP servers table when last displayed is deleted Found on bug 27251 which was mimicking SMTP server code for QOTD. To recreate: Create a SMTP server with name "a" Create a SMTP server with name "aa" Filter by "aa" => Only 1 row displayed Delete it, confirm => The table disappears Note that we could re-add this test when bug 27353 will be pushed, as recordsTotal will contain the unfiltered number of records in the DB. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
BTW : "Default configuration" message is quite big. We may move it to a button opening a modal popup ?
(In reply to Fridolin Somers from comment #3) > BTW : > "Default configuration" message is quite big. > We may move it to a button opening a modal popup ? That's a good idea.
Created attachment 115000 [details] [review] Bug 27356: Don't hide the SMTP servers table when last displayed is deleted Found on bug 27251 which was mimicking SMTP server code for QOTD. To recreate: Create a SMTP server with name "a" Create a SMTP server with name "aa" Filter by "aa" => Only 1 row displayed Delete it, confirm => The table disappears Note that we could re-add this test when bug 27353 will be pushed, as recordsTotal will contain the unfiltered number of records in the DB. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.02
Missing dependencies, not backported to 20.05