|
Description
Jonathan Druart
2021-01-12 09:25:26 UTC
Created attachment 115055 [details] [review] Bug 27403: Add fixedHeader to Datatables That's a great plugin to have fixed header. Test plan: On the cities table or the patron search table confirm that the header is floating is you scroll down Works well in both Chrome and Firefox, this will save a lot of confusion when looking at larger tables. Created attachment 115098 [details] [review] Bug 27403: Add fixedHeader to Datatables That's a great plugin to have fixed header. Test plan: On the cities table or the patron search table confirm that the header is floating is you scroll down Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> *** Bug 27417 has been marked as a duplicate of this bug. *** This appears to work quite well, but can you please add a note about the new plugin to the About page? Small thing: for a table like our current circulation conditions it's possible that the header line will hide the row with the input fields when scrolling down. Not sure this should be a blocker really - the feature is nice and people just need to scroll up a bit again. Created attachment 115314 [details] [review] Bug 27403: Add fixedHeader to Datatables That's a great plugin to have fixed header. Test plan: On the cities table or the patron search table confirm that the header is floating is you scroll down Sooo, actually we don't need to add the dataTables.fixedHeader.min.js file, the feature exists in the datatables.min.js file we embed. Created attachment 115323 [details] [review] Bug 27403: Add fixedHeader to Datatables That's a great plugin to have fixed header. Test plan: On the cities table or the patron search table confirm that the header is floating is you scroll down Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 115324 [details] [review] Bug 27403: (follow-up) Make basket toolbar and table header work together The fixed header option for DataTables does the same thing that the hcSticky jQuery plugin does for us on toolbars, so I've gone through the templates looking for places they might conflict. On the acquisitions basket page we can add a special class, "fh-fixedHeader," to the sticky toolbar to tell DataTables that the table header should float *below* the toolbar. To test, apply the patch and go to Acquisitions. - Locate a vendor and a basket for that vendor with multiple orders. - Adjust the browse window height if necessary to trigger vertical scrolling. - Confirm that as you scroll down the toolbar (with buttons "Add to basket," "Edit basket," etc) sticks to the top of the browser window. - Confirm that as you continue to scroll, the table header sticks below the floating toolbar. (In reply to Owen Leonard from comment #9) > I've gone through the > templates looking for places they might conflict. The only other instance I found was on the item search page, where there is some strange behavior. To reproduce: 1. Submit an item search that will return multiple results. 2. After the results have loaded, click the "Edit search" button. 3. As you scroll down, the toolbar sticks to the top of the browser window but then the table header jumps into view before the table of results has scrolled into view. Created attachment 115333 [details] [review] Bug 27403: Disable fixedHeader on itemsearch It does not work. Thanks for the follow-up, Owen! I have no idea about what's happening on the item search view so I am suggesting to simply disable fixedHeader on this page. Created attachment 116004 [details] [review] Bug 27403: (follow-up) Make basket toolbar and table header work together The fixed header option for DataTables does the same thing that the hcSticky jQuery plugin does for us on toolbars, so I've gone through the templates looking for places they might conflict. On the acquisitions basket page we can add a special class, "fh-fixedHeader," to the sticky toolbar to tell DataTables that the table header should float *below* the toolbar. To test, apply the patch and go to Acquisitions. - Locate a vendor and a basket for that vendor with multiple orders. - Adjust the browse window height if necessary to trigger vertical scrolling. - Confirm that as you scroll down the toolbar (with buttons "Add to basket," "Edit basket," etc) sticks to the top of the browser window. - Confirm that as you continue to scroll, the table header sticks below the floating toolbar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> (In reply to Jonathan Druart from comment #12) > Thanks for the follow-up, Owen! > > I have no idea about what's happening on the item search view so I am > suggesting to simply disable fixedHeader on this page. I think why this acts weird is because when you 'Edit search' we show the #item-search-block but the DataTable still thinks it is in the original location even though it has moved down on the page. You can use destory(), I think to make this work Created attachment 116005 [details] [review] Bug 27403: Possible item search fix 1. Submit an item search that will return multiple results. 2. After the results have loaded, click the "Edit search" button. 3. As you scroll down, the toolbar sticks to the top of the browser window but then the table header jumps into view before the table of results has scrolled into view. 4. Apply this patch and try again, the table header should not act weird. 5. Make sure all the dataTable controls still work (In reply to Lucas Gass from comment #15) > Created attachment 116005 [details] [review] [review] > Bug 27403: Possible item search fix This works at first but after clicking the "Edit search" button the DataTable doesn't work correctly. The configuration looks broken and not all results are accessible. I'm changing this to "Signed off" because I think the the follow-up which disables the feature on the item search page is acceptable. (In reply to Owen Leonard from comment #16) > (In reply to Lucas Gass from comment #15) > > Created attachment 116005 [details] [review] [review] [review] > > Bug 27403: Possible item search fix > > This works at first but after clicking the "Edit search" button the > DataTable doesn't work correctly. The configuration looks broken and not all > results are accessible. > > I'm changing this to "Signed off" because I think the the follow-up which > disables the feature on the item search page is acceptable. Sounds good! I'm obsoleting my patch in that case. I've checked: - inventory - patron search - item search (deactivated) - batch checkouts from patron account - list of checkouts in patron account - MARC bibliographic framework structure - Authorised value categories Of course there are more... but these all look ok. I am ready to PQA. Also acq baskets are ok! Created attachment 116524 [details] [review] Bug 27403: Add fixedHeader to Datatables That's a great plugin to have fixed header. Test plan: On the cities table or the patron search table confirm that the header is floating is you scroll down Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116525 [details] [review] Bug 27403: Disable fixedHeader on itemsearch It does not work. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116526 [details] [review] Bug 27403: (follow-up) Make basket toolbar and table header work together The fixed header option for DataTables does the same thing that the hcSticky jQuery plugin does for us on toolbars, so I've gone through the templates looking for places they might conflict. On the acquisitions basket page we can add a special class, "fh-fixedHeader," to the sticky toolbar to tell DataTables that the table header should float *below* the toolbar. To test, apply the patch and go to Acquisitions. - Locate a vendor and a basket for that vendor with multiple orders. - Adjust the browse window height if necessary to trigger vertical scrolling. - Confirm that as you scroll down the toolbar (with buttons "Add to basket," "Edit basket," etc) sticks to the top of the browser window. - Confirm that as you continue to scroll, the table header sticks below the floating toolbar. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x If this is the same feature, I think we are seeing some issues with orphaned column headers and bleed over from other tabs (like seeing the checkout headers on the holds tab though part of the scrolling). (In reply to Christopher Brannon from comment #25) > If this is the same feature, I think we are seeing some issues with orphaned > column headers and bleed over from other tabs (like seeing the checkout > headers on the holds tab though part of the scrolling). Hi Christopher, can you detail a bit more? Which Koha version? On which view are you seeing that? /circulation.pl?borrowernumber=5 on the "X checkout(s)" tab? Created attachment 128685 [details]
Floating header checkout bleed on holds tab
When on the holds tab in circulation.pl or moremember.pl, when you scroll down and just switch over to the floating header, the checkouts header appears on top of the holds header for a little bit until you scroll down further. I have seen this demonstrated on other systems, and have seen other tabs bleed over as well.
Ignore the comment about the orphaned column header. We hide a particular column through css (because it can't be turned off) and it was showing up in the floating toolbar. The other issue (checkout header appearing on the holds tab) still exists. |