|
Description
Aleisha Amohia
2021-01-20 01:08:44 UTC
Created attachment 115400 [details] [review] Bug 27473: Imrpoved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that the link does not include click and is easily understood I think the use of "this link" in the sentence is not better than "click here." I think something like simply "Continue to the next stage" would work. Created attachment 115627 [details] [review] Bug 27473: Imrpoved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Now the link is really long and still has the "link" - which I think we don't need to mention. The browser formatting and the screen readers will already transport that information. What about: Jump to onboarding process Created attachment 115643 [details] [review] Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Created attachment 115645 [details] [review] Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I'm not so sure about this change.. the two actions no longer seem related... it feels like you're now in a race against the reload to click a button you don't know where it goes... I am not sure why we have this delayed redirect at all, but it's been done like this forever. We step through all other parts of the installer process using buttons... :) I am going to propose "Continue with the onboarding process". Created attachment 116458 [details] [review] Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116459 [details] [review] Bug 27473: (follow-up) Change wording of the button Created attachment 117402 [details] [review] Bug 27473: Improved link text in installer Test Plan 1. run reset_all to run koha installer 2. Check that after importing sample data step that link says 'Continue to the next stage' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 117403 [details] [review] Bug 27473: (follow-up) Change wording of the button Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 117447 [details] [review] Bug 27473: (follow-up) Remove the redirect message I don't think it's necessary to remove the redirect because I don't think it does any harm, but why include a message about it? I think we should treat this step like all the others and provide a button to take the user to the next page. Created attachment 117448 [details] [review] Bug 27473: Remove the redirect after 10sec Then going a bit further and removing the redirect. Katrin, Martin, would you agree? Seems reasonable to me :) Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |