Summary: | Use Modern::Perl in other misc scripts | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Architecture, internals, and plumbing | Assignee: | Eden <eden.bacani> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | eden.bacani, tomascohen |
Version: | unspecified | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 2505 | ||
Attachments: |
Bug 27483: Replaces use strict; and use warnings; with Modern::Perl
Bug 27483: Deleted unnecessary use warnings comments |
Description
Aleisha Amohia
2021-01-20 02:40:25 UTC
Created attachment 115409 [details] [review] Bug 27483: Replaces use strict; and use warnings; with Modern::Perl Test Plan 1. check on files below that use strict; and use warings; do not exist 2. check on files below that Modern::Perl exists misc/batchCompareMARCvsFrameworks.pl misc/batchDeleteUnusedSubfields.pl misc/batchImportMARCWithBiblionumbers.pl misc/batchRebuildBiblioTables.pl misc/cronjobs/build_browser_and_cloud.pl misc/exportauth.pl misc/kohalib.pl misc/translator/tmpl_process3.pl Still working on this Created attachment 115458 [details] [review] Bug 27483: Deleted unnecessary use warnings comments Test Plan 1. check on files below that use warings comments does not exist 2. check on files below that Modern::Perl does not exist as it is unnecessary. 3. Check that use strict; still exists misc/batchCompareMARCvsFrameworks.pl misc/batchDeleteUnusedSubfields.pl misc/batchImportMARCWithBiblionumbers.pl misc/batchRebuildBiblioTables.pl misc/cronjobs/build_browser_and_cloud.pl misc/exportauth.pl misc/kohalib.pl misc/translator/tmpl_process3.pl Still working on it ready for testing Hi, Eden. The idea is to introduce use Modern::Perl; Modern::Perl implies use strict; use warnings; which is desirable. The idea is you should replace use strict; #use warnings; for use Modern::Perl; and it will make some warnings show up. And those need to be fixed. |