Bug 27485

Summary:	Rename system preference gist to TaxRates
Product:	Koha	Reporter:	Aleisha Amohia <aleisha>
Component:	Architecture, internals, and plumbing	Assignee:	Bugs List <koha-bugs>
Status:	CLOSED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	enhancement
Priority:	P5 - low	CC:	caroline.cyr-la-rose, fridolin.somers, m.de.rooy
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.05.00
Circulation function:
Bug Depends on:
Bug Blocks:	10327
Attachments:	Bug 27485: Rename system preference gist to TaxRates Bug 27485: Rename system preference gist to TaxRates Bug 27485: Rename system preference gist to TaxRates

Description Aleisha Amohia 2021-01-20 03:03:53 UTC

find all of the places in the code that refer to the 'gist' system preference and rename them to 'TaxRates'
write an atomic update to rename the gist system preference to TaxRates in the preferences table in the database
rename the gist syspref in sysprefs.sql

refer to bug 10328 for an example

Comment 1 Mazen Khallaf 2021-01-20 21:27:17 UTC

Created attachment 115462 [details] [review]
Bug 27485: Rename system preference gist to TaxRates

Test Plan:

1. Create a vendor
2. Create a basket
3. Add an order to the basket (note the existence of the option 'gist'
4  Apply patch
5. Create another order (note the existence of the option 'TaxRates'
    instead)
6. Run 'prove t/Prices.t' to confirm the tests were successful
7. If everything above is correct then patch was successful

Comment 2 Katrin Fischer 2021-01-21 23:12:18 UTC

Created attachment 115644 [details] [review]
Bug 27485: Rename system preference gist to TaxRates

Test Plan:

1. Create a vendor
2. Create a basket
3. Add an order to the basket (note the existence of the option 'gist'
4  Apply patch
5. Create another order (note the existence of the option 'TaxRates'
    instead)
6. Run 'prove t/Prices.t' to confirm the tests were successful
7. If everything above is correct then patch was successful

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 3 Katrin Fischer 2021-01-21 23:12:50 UTC

As hard as I tried, I couldn't find any remaining gist!

Comment 4 Marcel de Rooy 2021-01-22 08:18:03 UTC

QA: Looking here

Comment 5 Marcel de Rooy 2021-01-22 08:42:01 UTC

Created attachment 115665 [details] [review]
Bug 27485: Rename system preference gist to TaxRates

Test Plan:

1. Create a vendor
2. Create a basket
3. Add an order to the basket (note the existence of the option 'gist'
4  Apply patch
5. Create another order (note the existence of the option 'TaxRates'
    instead)
6. Run 'prove t/Prices.t' to confirm the tests were successful
7. If everything above is correct then patch was successful

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 6 Marcel de Rooy 2021-01-22 08:42:42 UTC

Great Mazen. The name of this pref was one of the most confusing in Koha for a long time.

Comment 7 Jonathan Druart 2021-01-22 13:54:55 UTC

Pushed to master for 21.05, thanks to everybody involved!

Comment 8 Fridolin Somers 2021-01-29 13:30:12 UTC

Enhancement not pushed to 20.11.x