Created attachment 18377 [details] [review] Bug 10328 - Rename opaccolorstylesheet to OpacColorStyleSheet Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify the system pref OpacColorStyleSheet still works i.e. no change should be noted
If we're renaming this one, maybe we should rename it to something which better describes its use? It's not really a stylesheet for color, even though that was the original intention.
Created attachment 18719 [details] [review] Bug 10328 - Rename opaccolorstylesheet to OpacColorStyleSheet Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Kyle, what do you think about the Owen's proposition? Owen, what do you suggest? Switch to in discussion.
I like Jared's suggestion from IRC, "OpacAdditionalStylesheet"
(In reply to Owen Leonard from comment #5) > I like Jared's suggestion from IRC, "OpacAdditionalStylesheet" +1 from me too
Created attachment 36123 [details] [review] Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet
I think the changes to installer/data/mysql/updatedatabase.pl are missing in this patch (Attachment #36123 [details]). They were in previous, obsoleted patch (Attachment #18719 [details]).
Created attachment 36156 [details] [review] Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet
(In reply to Marc Véron from comment #8) > I think the changes to installer/data/mysql/updatedatabase.pl are missing in > this patch (Attachment #36123 [details]). > They were in previous, obsoleted patch (Attachment #18719 [details]). Yes of course, thanks for the catch Marc!
Created attachment 36172 [details] [review] [Signed-off] Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet Test plan (from comment #1) 1) Apply this patch 2) Run updatedatabase.pl 3) Verify the system pref OpacColorStyleSheet still works i.e. no change should be noted Additionally, I changed the path to an other stylesheet and verified that it worked. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 36409 [details] [review] [PASSED QA] Bug 10328 - Rename opaccolorstylesheet to OpacAdditionalStylesheet Test plan (from comment #1) 1) Apply this patch 2) Run updatedatabase.pl 3) Verify the system pref OpacColorStyleSheet still works i.e. no change should be noted Additionally, I changed the path to an other stylesheet and verified that it worked. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and no more occurences of opaccolorstylesheet were found.
Patch pushed to master. Thanks Jonathan!