Bug 27486

Summary: Rename system preference delimiter to CSVDelimiter
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Architecture, internals, and plumbingAssignee: Mazen Khallaf <mazen.i.khallaf>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, sally.healey
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Medium patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.05.00
Bug Depends on:    
Bug Blocks: 10327, 28327    
Attachments: Bug 27486: Rename system preference delimiter to CSVDelimiter
Bug 27486: Rename system preference delimiter to CSVDelimiter
Bug 27486: Rename system preference delimiter to CSVDelimiter
Bug 27486: Rename system preference delimiter to CSVDelimiter
Bug 27486: (QA follow-up) Fix occurence in aqplan.pl
Bug 27486: Replace one missing occurrence
Bug 27486: Fix UsageStats.t

Description Aleisha Amohia 2021-01-20 03:11:29 UTC
find all of the places in the code that refer to the 'delimiter' system preference and rename them to 'CSVDelimiter'
write an atomic update to rename the delimiter system preference to CSVDelimiter in the preferences table in the database
rename the delimiter syspref in sysprefs.sql

refer to bug 10328 for an example
Comment 1 Mazen Khallaf 2021-01-21 01:50:13 UTC
Created attachment 115485 [details] [review]
Bug 27486: Rename system preference delimiter to CSVDelimiter

Test Plan:

1. Go to Administration
2. Go to System Preferences
3. Find 'delimiter' (note the name)
4. Apply patch
5. Repeat step 1 and 2
6. Find 'CSVDelimiter' (note the name)
Comment 2 Owen Leonard 2021-01-21 13:08:10 UTC
This works well and the test passes, but the QA tool raises this warning:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/.basketgroup.tt.swp
   FAIL	  invalid file
		This file must not be added to the codebase
Comment 3 Mazen Khallaf 2021-01-21 20:26:54 UTC
Created attachment 115618 [details] [review]
Bug 27486: Rename system preference delimiter to CSVDelimiter

Test Plan:

1. Go to Administration
2. Go to System Preferences
3. Find 'delimiter' (note the name)
4. Apply patch
5. Repeat step 1 and 2
6. Find 'CSVDelimiter' (note the name)
Comment 4 PTFS Europe Sandboxes 2021-01-25 11:25:20 UTC
Created attachment 115742 [details] [review]
Bug 27486: Rename system preference delimiter to CSVDelimiter

Test Plan:

1. Go to Administration
2. Go to System Preferences
3. Find 'delimiter' (note the name)
4. Apply patch
5. Repeat step 1 and 2
6. Find 'CSVDelimiter' (note the name)

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 5 Sally 2021-01-25 11:25:47 UTC
Works as described.
Comment 6 Katrin Fischer 2021-01-28 22:14:34 UTC
Created attachment 115996 [details] [review]
Bug 27486: Rename system preference delimiter to CSVDelimiter

Test Plan:

1. Go to Administration
2. Go to System Preferences
3. Find 'delimiter' (note the name)
4. Apply patch
5. Repeat step 1 and 2
6. Find 'CSVDelimiter' (note the name)

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2021-01-28 22:14:37 UTC
Created attachment 115997 [details] [review]
Bug 27486: (QA follow-up) Fix occurence in aqplan.pl

There was another mention of the old system preference name in the
budget planning code. This patch replaces it with the new name.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Jonathan Druart 2021-01-29 07:12:26 UTC
Created attachment 116009 [details] [review]
Bug 27486: Replace one missing occurrence
Comment 9 Jonathan Druart 2021-01-29 08:00:06 UTC
Pushed to master for 21.05, thanks to everybody involved!
Comment 10 Jonathan Druart 2021-02-01 09:37:05 UTC
Created attachment 116140 [details] [review]
Bug 27486: Fix UsageStats.t
Comment 11 Jonathan Druart 2021-02-01 09:39:37 UTC
Follow-up pushed to master.
Comment 12 Fridolin Somers 2021-02-05 15:32:41 UTC
Enhancement not pushed to 20.11.x