|
Description
Aleisha Amohia
2021-01-20 03:49:11 UTC
instead of StaffInterfaceLanguage, make that StaffInterfaceLanguages Created attachment 169631 [details] [review] Bug 27490: Update systempreference 'language' to 'StaffInterfaceLanguages' Test plan 1. Go to the staff client 2. Go to administration 3. Search systempreferences for 'StaffInterfaceLanguages' 4. Ensure there is a systempreference variable matching 'StaffInterfaceLanguages' Hi. Everything works as per the test plan. However, I tried with another language (de-DE) installed: - Before the patch, I can switch languages in the staff interface. - After the path, I can't switch languages. When trying to switch the language, the language didn't change and remained in English. (The OPAC worked correctly.) In addition, to get credit on the dashboard (https://dashboard.koha-community.org/), and to be listed as a Koha developer on the Koha timeline page, I think the assignee for the bug needs updating. I've changed the status to Failed QA 8-( David Testing notes (using koha-testing-docker (KTD)): 1. Apply the patch. 2. Update the database: updatedatabase 3. As per the test plan 4. To install another language: . koha-translate --install de-DE --dev kohadev . restart_all (not sure if this is really required) . enable the language: StaffInterfaceLanguages Created attachment 169805 [details] [review] Bug 27490: More instances of changing language syspref to StaffInterfaceLanguages Created attachment 169914 [details] [review] Bug 27490: Update systempreference 'language' to 'StaffInterfaceLanguages' Test plan 1. Go to the staff client 2. Go to administration 3. Search systempreferences for 'StaffInterfaceLanguages' 4. Ensure there is a systempreference variable matching 'StaffInterfaceLanguages' Signed-off-by: David Nind <david@davidnind.com> Created attachment 169915 [details] [review] Bug 27490: More instances of changing language syspref to StaffInterfaceLanguages Signed-off-by: David Nind <david@davidnind.com> I believe this is a good change, but we are missing a few occurences: installer/data/mysql/localization/de-DE/custom.sql:UPDATE systempreferences SET value = 'de-DE,en' WHERE variable = 'language'; installer/data/mysql/localization/fr-CA/custom.sql:UPDATE systempreferences SET value = 'fr-CA,en' WHERE variable = 'language'; installer/data/mysql/localization/fr-FR/custom.sql:UPDATE systempreferences SET value = 'fr-FR' WHERE variable = 'language'; installer/data/mysql/localization/it-IT/custom.sql:UPDATE systempreferences SET value = 'en,it-IT' WHERE variable = 'language'; installer/data/mysql/localization/nb-NO/custom.sql:UPDATE systempreferences SET value = 'nb-NO' WHERE variable = 'language'; installer/data/mysql/localization/ru-RU/custom.sql:UPDATE systempreferences SET value = 'ru-RU,uk-UA,en,fr-FR,de-DE' WHERE variable = 'language'; I believe this was a Catathon patch - please let us know if you need help with the follow-up or someone to jump in here! (In reply to Katrin Fischer from comment #8) > I believe this was a Catathon patch - please let us know if you need help > with the follow-up or someone to jump in here! Yes, please feel free to follow up and jump in on fixing up this patch. It was a Catathon patch and I no longer have a Koha environment to continue :) Created attachment 170965 [details] [review] Bug 27490: Update systempreference 'language' to 'StaffInterfaceLanguages' Test plan 1. Go to the staff client 2. Go to administration 3. Search systempreferences for 'StaffInterfaceLanguages' 4. Ensure there is a systempreference variable matching 'StaffInterfaceLanguages' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> Created attachment 170966 [details] [review] Bug 27490: More instances of changing language syspref to StaffInterfaceLanguages Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> Created attachment 170967 [details] [review] Bug 27490: (follow-up) Fix custom installer files Follow-up looks great, thanks Katrin (In reply to Martin Renvoize from comment #13) > Follow-up looks great, thanks Katrin Wasn't me :) Thanks Nicolas! Pushed for 24.11! Well done everyone, thank you! misc4dev needed adjustments, see https://gitlab.com/koha-community/koha-misc4dev/-/issues/80 |