Summary: | The "Accessibility advocate" role is not yet listed in the about page. | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | About | Assignee: | Eden <eden.bacani> |
Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, bolshawh, caroline.cyr-la-rose, eden.bacani, fridolin.somers, kyle, victor, wainuiwitikapark |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.07,20.05.14,19.11.20
|
|
Circulation function: | |||
Attachments: |
Bug 27495: Added Accessibility advocate role in team page
Bug 27495: Added Accessibility advocate role in team page Bug 27495: Added Accessibility advocate role in team page |
Description
Martin Renvoize (ashimema)
2021-01-20 10:08:52 UTC
This should be reasonably straight forward to achieve.. we need to add the current position to the `/docs/teams.yaml` file and also add handling for it in the about page include file `koha-tmpl/intranet-tmpl/prog/en/includes/about-team.inc`. Created attachment 115473 [details] [review] Bug 27495: Added Accessibility advocate role in team page Test Plan 1. Click on 'About Koha' from the home page 2.Check on the Koha Team page that the role Accessibility advocate is listed under the Koha release teams and that the name of the person with the role appears. Created attachment 115517 [details] [review] Bug 27495: Added Accessibility advocate role in team page Test Plan 1. Click on 'About Koha' from the home page 2.Check on the Koha Team page that the role Accessibility advocate is listed under the Koha release teams and that the name of the person with the role appears. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looks great, thanks Eden. Signing off. Created attachment 115572 [details] [review] Bug 27495: Added Accessibility advocate role in team page Test Plan 1. Click on 'About Koha' from the home page 2.Check on the Koha Team page that the role Accessibility advocate is listed under the Koha release teams and that the name of the person with the role appears. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Needs to be backported to stable ? Hmm, debatable.. we do show the current team on the about page so perhaps worthwhile.. someone may want to query current accessabilty [U+1F642] Pushed to 20.11.x for 20.11.07 Backported: Pushed to 20.05.x branch for 20.05.13 Should this be backported to 19.11.x? If so, this would be for 19.11.20 (next release in July) as I believe there is currently a string freeze so this bug should not be backported now? Nice catch, thanks. It's indeed string freeze. Reverted. Backported: Pushed to 20.05.x branch for 20.05.14 Should this be backported to 19.11.x? It was backported to avoid a conflict when backporting bug 28442. Fridolin found that out. Even if the conflict shouldn't be hard to solve, it felt easier to backport this without giving much though about it. Since it doesn't seem a risky change. And it's nice to have the accessibility advocate role listed. So it can be either be backported or not to 19.11.x , both would work ^^ Backported to 19.11.x for 19.11.20 |