| Summary: | Correct 'accepted by' inconsistency in suggestion.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Blou <philippe.blouin> |
| Component: | Acquisitions | Assignee: | Blou <philippe.blouin> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, caroline.cyr-la-rose, fridolin.somers, jonathan.druart, lucas, marjorie.barry-vila, philippe.blouin, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.03,20.05.09
|
|
| Circulation function: | |||
| Bug Depends on: | 23590 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt
Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt Bug 27608: [20.05] Corrects 'accepted by' inconsistency in suggestion.tt |
||
|
Description
Blou
2021-02-03 16:45:21 UTC
Created attachment 116288 [details] [review] Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. Sponsored by: Collecto (formerly CCSR) Created attachment 116341 [details] [review] Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 116450 [details] [review] Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Excellent catch :) Caused by commit 0370e0dcd2585c3de0245718c6da43ad86f82ae8 Bug 23590: Clean TT variables for patrons Created attachment 116499 [details] [review] Bug 27608: Corrects 'accepted by' inconsistency in suggestion.tt When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. Sponsored-by: Collecto Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: Add sponsor line Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Doesn't apply cleanly to 20.05. Please rebase. Thanks! Created attachment 116974 [details] [review] Bug 27608: [20.05] Corrects 'accepted by' inconsistency in suggestion.tt When looking at an accepted suggestion in suggestion.pl, under 'Suggestion management', the displayed cardnumber in parenthesis is the wrong one. It displays the "suggestedby"'s cardnumber instead of the acceptedby. Test: - create a suggestion in OPAC or staff client with user A. - In staff client, go to accept it with User B. - Click Edit - Under section "Suggestion management", you have a "Accepted on". - In the By column, the cardnumber in parenthsis is not the B one. - Apply patch, refresh. Looking at the code patch is self-explanatory. Sponsored-by: Collecto Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: Add sponsor line Pushed to 20.05.x for 20.05.09. Thanks! Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |