Bug 27664

Summary:	pickupNotInHoldGroup is too generic
Product:	Koha	Reporter:	Tomás Cohen Arazi (tcohen) <tomascohen>
Component:	Hold requests	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27071
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description Tomás Cohen Arazi (tcohen) 2021-02-09 15:41:29 UTC

There are actually two codepaths that yield an output of 'pickupNotInHoldGroup' in C4::Reserves::CanItemBeReserved:
- The passed pickup location doesn't match the patron's hold group
- The passed pickup location doesn't match the item's hold group

We could return different error codes and provide better feedback to the end user.

Comment 1 Katrin Fischer 2023-01-23 22:23:50 UTC

This appears to still be valid:

C4/Reserves.pm:         { status => pickupNotInHoldGroup }, pickup location is not in hold group, and pickup locations are only allowed from hold groups.
C4/Reserves.pm:            return { status => 'pickupNotInHoldGroup' };
C4/Reserves.pm:            return { status => 'pickupNotInHoldGroup' };
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:                                                                [% ELSIF itemloo.not_holdable == 'pickupNotInHoldGroup' %]
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:            pickupNotInHoldGroup: _("Only pickup locations within the same hold group are allowed")