Bug 27664 - pickupNotInHoldGroup is too generic
Summary: pickupNotInHoldGroup is too generic
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-09 15:41 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2023-01-23 22:23 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2021-02-09 15:41:29 UTC 
There are actually two codepaths that yield an output of 'pickupNotInHoldGroup' in C4::Reserves::CanItemBeReserved:
- The passed pickup location doesn't match the patron's hold group
- The passed pickup location doesn't match the item's hold group

We could return different error codes and provide better feedback to the end user.
Comment 1 Katrin Fischer 2023-01-23 22:23:50 UTC 
This appears to still be valid:

C4/Reserves.pm:         { status => pickupNotInHoldGroup }, pickup location is not in hold group, and pickup locations are only allowed from hold groups.
C4/Reserves.pm:            return { status => 'pickupNotInHoldGroup' };
C4/Reserves.pm:            return { status => 'pickupNotInHoldGroup' };
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:                                                                [% ELSIF itemloo.not_holdable == 'pickupNotInHoldGroup' %]
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:            pickupNotInHoldGroup: _("Only pickup locations within the same hold group are allowed")