Summary: | Missing include in orderreceive.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Acquisitions | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, m.de.rooy, tomascohen |
Version: | Main | Keywords: | rel_20_11_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.05.00,20.11.03
|
Circulation function: | |
Bug Depends on: | 23376 | ||
Bug Blocks: | 26693 | ||
Attachments: |
Bug 27671: Restore missing include in orderreceive.tt
Bug 27671: Restore missing include in orderreceive.tt Bug 27671: Restore missing include in orderreceive.tt Bug 27671: Use Koha.Preference for UniqueItemFields Bug 27671: Restore missing include in orderreceive.tt Bug 27671: Use Koha.Preference for UniqueItemFields |
Description
Tomás Cohen Arazi (tcohen)
2021-02-10 14:03:26 UTC
Created attachment 116669 [details] [review] Bug 27671: Restore missing include in orderreceive.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 116686 [details] [review] Bug 27671: Restore missing include in orderreceive.tt Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 116693 [details] [review] Bug 27671: Restore missing include in orderreceive.tt Caused by commit 15e35f77fb29137a5421ff79a1186087508aa68f Bug 23376: Move AcqCreateItem logic to template Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> This is definitely correct, but it doesn't solve the issue I see To test: 1 - Set AcqCreateItem to 'receiving an order' 2 - Set UniqueItemFields to barcode|materials 3 - Add the words 'qwertytest' to materials field for existing item 4 - Attempt to receive an item, adding 'qwertytest' to the materials field Both before and after the patch I was warned of duplicate information, no matter what values I had in the materials or barcode field Created attachment 116770 [details] [review] Bug 27671: Use Koha.Preference for UniqueItemFields Created attachment 116784 [details] [review] Bug 27671: Restore missing include in orderreceive.tt Caused by commit 15e35f77fb29137a5421ff79a1186087508aa68f Bug 23376: Move AcqCreateItem logic to template Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 116785 [details] [review] Bug 27671: Use Koha.Preference for UniqueItemFields Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Missing dependencies, not backported to 20.05 |