| Summary: | Add a floating table header for Search engine configuration | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Séverine Queune <severine.queune> |
| Component: | Searching - Elasticsearch | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | alex.arnaud, david, fridolin.somers, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement adds a search filter and a floating table header (that "sticks" to the top of the browser window as you scroll down) to the search engine configuration pages (Administration > Catalog > Search engine configuration (Elasticsearch)).
The "Search fields" table is sortable, but the "Bibliographic records" and "Authorities" tables are not as they have drag-and-drop row reordering.
|
Version(s) released in: |
21.05.00
|
| Circulation function: | |||
| Bug Depends on: | 27403 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 27682: Add a floating table header for Search engine configuration
Bug 27682: Add a floating table header for Search engine configuration Bug 27682: Add a floating table header for Search engine configuration Bug 27682: (follow-up) Make sure table is drawn with correct width |
||
|
Description
Séverine Queune
2021-02-11 13:10:48 UTC
Created attachment 117088 [details] [review] Bug 27682: Add a floating table header for Search engine configuration This patch adds DataTables options to the tables on the search engine configuration pages. The table on the "Search fields" tab will be sortable, all tables will be searchable, and all tables will have floating headers. To test you should have the SearchEngine preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - Test the tables under each tab, "Search fields," "Bibliographic records," and "Authorities," the table has a search filter and the header row "sticks" to the top of the browser window as you scroll down. - The "Search fields" table should be sortable, but the other two should not--they have drag-and-drop row reordering. Created attachment 117104 [details] [review] Bug 27682: Add a floating table header for Search engine configuration This patch adds DataTables options to the tables on the search engine configuration pages. The table on the "Search fields" tab will be sortable, all tables will be searchable, and all tables will have floating headers. To test you should have the SearchEngine preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - Test the tables under each tab, "Search fields," "Bibliographic records," and "Authorities," the table has a search filter and the header row "sticks" to the top of the browser window as you scroll down. - The "Search fields" table should be sortable, but the other two should not--they have drag-and-drop row reordering. Signed-off-by: David Nind <david@davidnind.com> Created attachment 117422 [details] [review] Bug 27682: Add a floating table header for Search engine configuration This patch adds DataTables options to the tables on the search engine configuration pages. The table on the "Search fields" tab will be sortable, all tables will be searchable, and all tables will have floating headers. To test you should have the SearchEngine preference set to "Elasticsearch." - Apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - Test the tables under each tab, "Search fields," "Bibliographic records," and "Authorities," the table has a search filter and the header row "sticks" to the top of the browser window as you scroll down. - The "Search fields" table should be sortable, but the other two should not--they have drag-and-drop row reordering. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> 1. There is a weird behaviour, when you hit land on the page the floating header is wider than the thead. However if you go to the bibliographic or authorities tab and come back, it's ok. 2. tableInit( "", "search_fields"); In tableInit we should test if oldtabid is passed. Created attachment 117759 [details] [review] Bug 27682: (follow-up) Make sure table is drawn with correct width The DataTables plugin calculates the width of the fixed header based on the initial width of the corresponding table. Since these tables are inside jQueryUI tabs, the width changes when the tabs are initialized and jQueryUI adds its classes to the table's container. This patch "manually" adds the relevant classes to the markup so that the table's container is drawn with the right padding from the start. Also fixed: Don't try to destroy "oldTableId" if the tableInit function didn't pass an oldtabid. Pushed to master for 21.05, thanks to everybody involved! Super enhancement. I'd like to see it in 20.11.x. I've applied patches with a small conflict but table header is not floating :( Can you create patches for 20.11.x please ? (In reply to Fridolin Somers from comment #7) > Can you create patches for 20.11.x please ? The feature depends on Bug 27403. I've updated the dependencies to reflect it. (In reply to Owen Leonard from comment #8) > (In reply to Fridolin Somers from comment #7) > > > Can you create patches for 20.11.x please ? > > The feature depends on Bug 27403. I've updated the dependencies to reflect > it. Ok super thanks. In the end this is too much a change for stable branch. One can always cherry-pick the patches ;) Enhancement not pushed to 20.11.x *** Bug 20588 has been marked as a duplicate of this bug. *** |