Summary: | Add a dedicated self checkout (SCO) issue slip | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Failed QA --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, gmcharlt, kyle.m.hall, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 27696: add SCOSlipChoice system pref
Bug 27696: add SCOSlipChoice system pref |
Description
Lucas Gass (lukeg)
2021-02-12 17:34:57 UTC
Created attachment 116840 [details] [review] Bug 27696: add SCOSlipChoice system pref To test: 1. Apply patch, updatedatabase. 2. Look for the new system preference SCOSlipChoice. 3. Make sure your ISSUESLIP and ISSUEQSLIP have different info in them so you can differentiate between the two. 3. Switch SCOSlipChoice to ISSUESLIP, make sure the SCO now prints the issue slip. 4. Switch SCOSlipChoice to ISSUEQSLIP, make sure the SCO now prints the issue quick slip. Created attachment 117349 [details] [review] Bug 27696: add SCOSlipChoice system pref To test: 1. Apply patch, updatedatabase. 2. Look for the new system preference SCOSlipChoice. 3. Make sure your ISSUESLIP and ISSUEQSLIP have different info in them so you can differentiate between the two. 3. Switch SCOSlipChoice to ISSUESLIP, make sure the SCO now prints the issue slip. 4. Switch SCOSlipChoice to ISSUEQSLIP, make sure the SCO now prints the issue quick slip. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I hate to complicate things, but would it be simpler to give SCO it's own slip? I've got no problem with this solution as it stands. (In reply to Kyle M Hall from comment #3) > I hate to complicate things, but would it be simpler to give SCO it's own > slip? I've got no problem with this solution as it stands. It is more complicated but I do like this idea. +1 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES [...] +('SCOSlipChoice' , '0', 'issueqlsip', 'issueqslip|issueslip', 'Allow choice for SCO receipt print', 'Choice' ), The fields do not match! Value 0 is not correct. The options are not correct too etc. Please make sure that the former default == qslip is inserted. Note that it is confusing too that the sco script tests for qslip and our values are issueslip and issueqslip. sco script contains: if (my $letter = IssueSlip ($session->param('branch') || $branch, $borrowernumber, $print eq "qslip")) { We even have wrong calls in a test like: t/db_dependent/Members/IssueSlip.t: $slip = IssueSlip( $branchcode, $borrowernumber, 'quickslip' ); I would recommend to correct that too. (In reply to Lucas Gass from comment #4) > (In reply to Kyle M Hall from comment #3) > > I hate to complicate things, but would it be simpler to give SCO it's own > > slip? I've got no problem with this solution as it stands. > > It is more complicated but I do like this idea. +1 +1 Still valid. Lucas, this is assigned to you - is this correct? |